Add Preference to allow simple HTML through on nodes.

My mistake... the allowance of HTML is done in the Mime Mail module when used with Subscriptions — except that Subscriptions strips it's own HTML out of the node body. I just need to have a preference allowing the node body to have HTML in it, by disabling that one line of code.

I will see if I can write a patch to accomplish this in the next week or so. Shall I work off of 6.x-1.x-dev or 6.x.1.4?

Attached is the patch. Please put it up in a new 1.5 release of you could. Thank you Salvis! :-)
(This is rolled on the 6.x-1.x-dev version)

Attached is an even BETTER patch, which includes the changes my patch in #3 does, plus adds another much needed addition to your module... the ability to have an external mail template sourced from the Theme directory.

My addition just looks in the theme directory for a copy of the subscriptions_mail.templates.inc file and uses it if it exists, instead of the one in the modules directory.

Please take a look at this patch, and use it in a 1.5 release if you could. Thanks Salvis.

This patch is rolled in 6.x-1.x-dev and will finally free my customizations from the module directory completely! (if you release it) :-)

(I've fully tested this on my production site: www.kpbj.com)

This looks good, except we need to pass it through the filter of the node.

Ummm... huh? :-)

The filter already applies since the node is created before the subscription gets created, right? How in the world would my changes have disrupted that at all, since it is functioning exactly as before except for the location of the template file and the removal of the one line of code that strips-out the html (that the node filter already allowed to be there)?

Wait... I think I might see what you mean. However, I have no idea how to accomplish this, and actually would prefer it if my filters were not applied to the node body for emails...

Yes. No filter at all is what I would like -- just the raw node body that was created without any post-processing. Many of the post-processing filters would never work in an email anyway, like Lightbox, curly-quotes, etc, etc... We could just leave a disclaimer on the checkbox... there's no way to do every node filter possibility even if we tried, but at least this allows SOME raw HTML though so images and links will work.

How would raw HTML in an email, that already exists in the website, make someone open to attack? The worst it would do is email everyone raw HTML, and plain old HTML with no Javascript or anything is never a security risk is it?

How can this be done? Is it difficult?

Or, maybe instead of just removing all HTML, we could customize a filter of our own that specifically allows all "p", "a" and "img" tags, etc?

Also, the order in hook_uninstall() should be alphabetical.

LOL really?

The other code is inacceptable as it is because of duplication and broken indenting.

I'm not sure what you mean -- you mean the code syntax indenting? I wasn't sure how to make it not duplicate... can you help me out with this? Do I make a function containing this:

global $theme_path;
if (is_file($theme_path .'/subscriptions_mail.templates.inc')) {
   include_once $theme_path .'/subscriptions_mail.templates.inc';
}
else {
   include_once drupal_get_path('module', 'subscriptions_mail') .'/subscriptions_mail.templates.inc';
}

Ok ok ok... new patch. See if you like it. I think it addresses your issues. :)

Indented correctly? Check.
Duplications rewritten? Check.
hook_uninstall() alphabetical? Check.
README updated? Check.
Tested on production site? Check.

New patch. See attached...

By the way, just because someone doesn't organize the way you do doesn't mean they "enjoy creating chaos." I happened to have purposefully put the variable_del('subscriptions_allow_html_node_output'); code next to the other variable deletion referencing the "node" portion of the process. I figured that the database could care less the way it was organized, so I apparently made the wrong choice. Sorry. :-/

Thank you Salvis. I honestly hadn't noticed the alphabetization at all until you mentioned it.