Forum_block contains hardcoded HTML that is not passed trough the theme layer.

CommentFileSizeAuthor
#3 theme_more_link0.patch4.94 KBfloretan
#1 forum.module0.patch1.64 KBfloretan

Comments

floretan’s picture

floretan commented
Status: Active » Needs review
StatusFileSize
new forum.module0.patch1.64 KB

Here's a patch that creates a template file forum-block.tpl.php and replaces the hard-coded html in forum_block by a call to theme('forum-block', $content).

floretan’s picture

floretan commented
Status: Needs review » Active

sorry, I just realized some issues with my patch. I need to do more work on it, please ignore it for now.

floretan’s picture

floretan commented
Component: forum.module » theme system
Status: Active » Needs review
StatusFileSize
new theme_more_link0.patch4.94 KB

This patch replaces the hardcoded HTML for the "more" link on blocks with a theme function.

The bug was originally reported for the forum block, but this patch fixes the same issue for the aggregator and blog blocks as well.

The patch has been tested with all modified blocks.

floretan’s picture

floretan commented
Title: remove unthemable, hardcoded HTML from forum block » theme function for the "more" link on blocks
Assigned: Unassigned » floretan
dmitrig01’s picture

dmitrig01 commented
Category: bug » feature
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

I was thinking about whether using l() in the theme function would be better, but now that we already have the url(), this seemed like overkill. And we are already in a theme function. So committed the patch as-is. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.