First off, I do understand that the CP Shipping Quotes module, like other shipping quote modules, use a hard coded package dimension size when submitting information for a quote from Canada Post. I get the rational. Typically, the dimensions are not a factor in the quote.

This works fine *most* of the time. It works for one of my site *most* of the time. However, while most of my products fit in a small box, I have a small handful of products which are oversized. Therefore, I get shipping quotes for Canada Post services which are not applicable to the size of the product, and neglects the oversize surcharges.

I propose a hack to the way dimensions are submitted to CP. I'm posting now to get feedback as to whether not such a hack to the module would be accepted by the community.

Specifically, what I have in mind is that the code in _uc_canadapost_package_products be modified such that each package inherits the size of the largest product for that package. I propose the size of the largest product because it works for me. My largest item will always be in 1 package. Also, trying to calculate a package size from multiple products will almost always be wrong.

Next, _uc_canadapost_build_xml needs to be modified to use the package dimensions rather than the hard coded dimensions.

I think these changes would be at least harmless, and at best beneficial in a small number of cases. I'm not bothering with coding this up for myself at the moment because I can live without it. The number of oversized products we have is small, and low volume. We can always get back to the customer to tell them that the shipping quote they received was incorrect and let them know the new rate. Obviously I'd rather never have to do that.

If such a change would be acceptable, I wouldn't mind doing the coding myself and submitting the changes here.

Comments?