Download & Extend

Properly namespace defines

Project:Apps
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

There were 4 defines that were fairly general words that were not namespaced. ENABLED, DISABLED, INCOMPATIBLE, INSTALLABLE. The attached patch prefixes all of them with APPS_.

AttachmentSize
app-define-namespacing.patch5.63 KB

Comments

#1

Also, just to note, incompatable is a misspelling so I changed the define and user facing string occurrences of it. Should probably do the same with all variables, but I did not want to change too much at once.

#2

Status:needs review» fixed

To also apply the patch for the update tab I had to apply this since there was a ton of overlap. Reopen if it creates issues.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here