When two nodes have the exact timestamp flippy gets stuck in a loop, each image pointing to the next image!

CommentFileSizeAuthor
#7 Two_Nodes_With_Same_Timestamp-1476028-7.patch956 bytesrli
#6 Two_Nodes_With_Same_Timestamp-1476028-6.patch882 bytesrli
#5 flippy-duplicate-created-1476028-1.patch1.71 KBSchnaaf
#3 prevent_loop_for_nodes_with_the_same_created_value.patch948 bytesSchnaaf

Comments

greg.franklin’s picture

greg.franklin commented

I ran into this problem and solved it by modifing the prev / next queries to this:

$prev = clone $query;
$list['prev'] = $prev
  ->condition(db_or()
    ->condition('created', $node->created, '<')
    ->condition(db_and()
      ->condition('created', $node->created, '=')
      ->condition('nid', $node->nid, '<')))
  ->orderBy('created', 'DESC')
  ->execute()->fetchAssoc();

$next = clone $query;
$list['next'] = $next
  ->condition(db_or()
    ->condition('created', $node->created, '>')
    ->condition(db_and()
      ->condition('created', $node->created, '=')
      ->condition('nid', $node->nid, '>')))
  ->orderBy('created', 'ASC')
  ->execute()->fetchAssoc();
MGParisi’s picture

MGParisi commented

Thanks can you write a .PATCH?

Schnaaf’s picture

Schnaaf commented
StatusFileSize
new prevent_loop_for_nodes_with_the_same_created_value.patch948 bytes

the patch for this issue. I hope I got this right, it's my first patch...

MGParisi’s picture

MGParisi commented
Status: Active » Needs review

I was JUST thinking about this. Ill test it today:) I don't BELIEVE that is right format... did you use git?

Edit: duh, of course you used git. its close, there is instructions on the module page on how to do this http://drupal.org/project/flippy/git-instructions there is also an IRC channel... sometimes you need to wave your hands around in the contrib channel to get some help, because people dont watch it but are willing/eager to help

Schnaaf’s picture

Schnaaf commented
StatusFileSize
new flippy-duplicate-created-1476028-1.patch1.71 KB

changed the patch by following MGParisi's instructions in comment #4.

rli’s picture

rli
Primary language English
Location Canberra
commented
StatusFileSize
new Two_Nodes_With_Same_Timestamp-1476028-6.patch882 bytes

Error occurred when applying the patch in #5.
Rewrote the patch.

rli’s picture

rli
Primary language English
Location Canberra
commented
StatusFileSize
new Two_Nodes_With_Same_Timestamp-1476028-7.patch956 bytes

Logic is wrong in #6.
Rewrite the patch for #5.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Needs review » Reviewed & tested by the community

Looks good - especially for migrations where many nodes are created at the same time.

rli’s picture

rli
Primary language English
Location Canberra
commented
Status: Reviewed & tested by the community » Fixed

committed to dev, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.