remove button removes wrong post

onionweb - May 29, 2007 - 12:59
Project:abuse
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

When you click remove, it removes the wrong post. It'll remove the post listed prior to the one it should remove.

#1

onionweb - May 30, 2007 - 14:11

I uninstalled completely and then re-installed this module.

After I did that, I got a couple pages of reports. The problem with the wrong post being referenced continues.

All the buttons on the pending page, all point to the first report. If you click a button that is at the bottom of the page, it will will remove the first post on the top of the page. All the buttons on all posts only reference the first post. Including "ban." It will ban the wrong user.

#2

onionweb - May 30, 2007 - 14:11
Priority:normal» critical

changed to critical

#3

anonymous5190 - August 7, 2007 - 03:56

I can confirm this problem as well - trying to figure out what's causing it, but not totally sure - maybe because the HTML forms all use the same names?

#4

anonymous5190 - August 8, 2007 - 02:07
Status:active» patch (code needs review)

I fixed this issue with the attached patch.
Most of the credit goes to this explanation, it just took me a lot of time to finally dig that up :)
I'm very new at this, so if anyone can confirm it works for them, that'd be good.

AttachmentSize
abuse.module.patch798 bytes

#5

jaydub - March 25, 2008 - 17:45
Status:patch (code needs review)» fixed

I'm not too sure I like the way the abuse reports are handled now what with
all the forms and the associated problems as seen in this issue. For now
I've fixed this and committed to CVS but I'd like to redo the abuse moderation
pages to use a different solution than just loads of forms.

#6

NITEMAN - April 7, 2008 - 22:09
Version:5.x-1.x-dev» 5.x-1.0-beta
Status:fixed» active

I've just updated the module to the last version (March 28, 2008 - 15:35) and the issue still happens. The form field "edit-abuse-operations-form-form-token" has the same value in all the comments.

#7

jaydub - May 21, 2008 - 17:27

Please try new development snapshot as this should
be fixed in there.

#8

yangru - June 13, 2008 - 04:07

yes, I've also encountered the same problem.
I had two abuses reported and clicked allow on the bottom report, the site refreshed and allowed the top report, not the bottom.

#9

NITEMAN - July 18, 2008 - 07:29
Version:5.x-1.0-beta» 5.x-1.x-dev
Status:active» fixed

Hello, first of all I'm sorry for the long time I took to revisite the issue.

I've tried last dev version and the bug is fixed.

Thank you very much

#10

Anonymous (not verified) - August 1, 2008 - 07:34
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.