I use polls infrequently and want them on the sidebar when they are active. But I don't want an inactive poll displayed for weeks or months.

This patch changes the SQL that selects the latest poll to display. It simply adds the requirement that the poll be active.

CommentFileSizeAuthor
#6 POLL_HEAD_PATCH.txt968 bytesPrometheus6
#3 poll_0.patch1.19 KBPrometheus6
poll.patch1.14 KBPrometheus6

Comments

Prometheus6’s picture

Prometheus6 commented

Should be vs. CVS instead of 4.5

dries’s picture

dries commented
  1. "JOIN poll p": should be "JOIN {poll} p" or things will break when database prefixing is used.
  2. "on p.nid=n.nid": should be "ON p.nid = n.nid". Use capital letters for SQL keywords, and put spaces around "=".

Other than that, this looks like a bug fix.

Prometheus6’s picture

Prometheus6 commented
Category: feature » bug
StatusFileSize
new poll_0.patch1.19 KB

Bug fix, yes, but I figured if no one complained in so long it was intentional. Or maybe most people that use polls use them frequently.

Two corrections to formatting, and braces around the table name added.

dries’s picture

dries commented
killes@www.drop.org’s picture

killes@www.drop.org commented

patch: **** malformed patch at line 12:

Prometheus6’s picture

Prometheus6 commented
Priority: Minor » Normal
StatusFileSize
new POLL_HEAD_PATCH.txt968 bytes
Steven’s picture

Steven commented

Your last patch did not include the join. I committed a fixed one to HEAD. I also got rid of the WHERE n.type = "poll" as it is already implicitly taken into account by doing an INNER JOIN on the poll table.

Anonymous’s picture

(not verified) commented