Closed (fixed)
Project:
Simplenews Scheduler
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Mar 2012 at 09:41 UTC
Updated:
22 May 2012 at 15:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
berdirDid that.
Comment #2
joachim commentedThe two function signatures don't seem to match?
Comment #3
berdirUps.
They are named differently, I think scheduler_node makes more sense, not sure if we should update the clone function.
Comment #4
berdirForgot the patch.
Comment #5
joachim commentedLet's call it $edition_node throughout. Committed the patch with this tweak.
- #1476744 by Berdir: Changed the edition alter hook name and added a parameter for the template scheduler node.
Comment #6
joachim commentedSince the original version of this hook was backported to D6, so should this change to it.
Comment #7
joachim commented*sigh*... except that getting hold of the template node in _simplenews_scheduler_new_edition() is going to require major rewriting of that function and testing to work with node cloning issues etc etc. Not sure it's worth it :/
Comment #8
joachim commentedWe should change the hook name for consistency and easier upgrading though: #1567442: backport change of name of edition alter hook.