Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.this patch is a follow up to http://drupal.org/node/147434#comment-251390 and http://drupal.org/node/147434#comment-251410.
this patch will move the public shared function db_query() as private function, which means different DB backend driver can have more flexibility to optimize and alter SQL before running it. currently, mysql/mysqli/pgsql driver just need to copy-and-paste db_query() into their own database.xxx.inc, but oracle and other DB drivers can feather more make use of this change ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal-6.x-dev.move-db_query-as-private-2.0.patch | 4.9 KB | hswong3i |
| drupal-6.x-dev.move-db_query-as-private.patch | 6.5 KB | hswong3i |
Comments
Comment #1
hswong3i commentedthis patch is required by oracle driver (http://drupal.org/node/39260) for feather more development. without this patch oracle driver will not able to optimize SQL query, or overcome the limitation of maximum 30 characters in naming.
Comment #2
drewish commentedcould the mysql version of db_query go into the database.mysql-common.inc file?
Comment #3
hswong3i commentedsurely that we can do so, and here is the patch ;-)
Comment #4
moshe weitzman commentedseems harmless, and gives DB backends quite a bit more flexibility. They can fully control own query processing.
Comment #5
Crell commentedI haven't had a chance to test the code for the patch, but the PDO driver I was / will be working on would require this anyway, so this gets a +1 from me, too. (It looks like it's just copy/paste work, from visual inspection.)
Comment #6
dries commentedCommitted! :)
Comment #7
(not verified) commented