this patch is a follow up to http://drupal.org/node/147434#comment-251390 and http://drupal.org/node/147434#comment-251410.

this patch will move the public shared function db_query() as private function, which means different DB backend driver can have more flexibility to optimize and alter SQL before running it. currently, mysql/mysqli/pgsql driver just need to copy-and-paste db_query() into their own database.xxx.inc, but oracle and other DB drivers can feather more make use of this change ;)

CommentFileSizeAuthor
#3 drupal-6.x-dev.move-db_query-as-private-2.0.patch4.9 KBhswong3i
drupal-6.x-dev.move-db_query-as-private.patch6.5 KBhswong3i

Comments

hswong3i’s picture

hswong3i commented
Status: Needs review » Needs work

this patch is required by oracle driver (http://drupal.org/node/39260) for feather more development. without this patch oracle driver will not able to optimize SQL query, or overcome the limitation of maximum 30 characters in naming.

drewish’s picture

drewish commented

could the mysql version of db_query go into the database.mysql-common.inc file?

hswong3i’s picture

hswong3i commented
StatusFileSize
new drupal-6.x-dev.move-db_query-as-private-2.0.patch4.9 KB

surely that we can do so, and here is the patch ;-)

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Reviewed & tested by the community

seems harmless, and gives DB backends quite a bit more flexibility. They can fully control own query processing.

Crell’s picture

Crell commented

I haven't had a chance to test the code for the patch, but the PDO driver I was / will be working on would require this anyway, so this gets a +1 from me, too. (It looks like it's just copy/paste work, from visual inspection.)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed! :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)