**I read all the documentation and issue queues**

I wanted to say that I think this module is super awesome! Great features and all that jazz especially with the work you did with the connection (now if I could get LinkedIn at the same point that would be rad)

From a usability perspective I think it would be great to stick the progress bar under/within the '.fb_connect' div class. The reason for this (and I realize perhaps a low priority) is that when you log into Facebook suddenly your details appears there so it to me it seems more usable if a progress appeared just below.

I was going to try and provide a patch but when I changed your jquery('body').prepend code to jquery('.fb_connect').append it shows the outline of the bar but nothing else. So I think there is more there that needs changing that perhaps I'm missing?

If you give me some direction I can work on this...?

Thanks

CommentFileSizeAuthor
#4 fb_progress.diff1.23 KBDave Cohen
#2 fb-1477000-2.patch458 bytesshaneonabike

Comments

Dave Cohen’s picture

Dave Cohen commented
Title: Progress bar at the top of the page » better reload/progress indicator
Category: task » feature
Issue tags: +get involved

I've tried to do the same thing, couldn't make it work. There's also code in fb_connect.js which fails indicate progress in the connect block.

I think ideally only the XFBML markup would change to indicate progress. Or, put a spinning wheel over the center of the page.

I don't have the javascript chops to make that sort of thing happen but if anyone does I'd love a patch.

shaneonabike’s picture

shaneonabike commented
StatusFileSize
new fb-1477000-2.patch458 bytes

I think that I might have resolved this... I took a two prong approach

* Append it to the bottom below the login details to show it right in front of where things change
* Otherwise (important for logout) attach it to body text

Sorry we don't have git on the server so I had to use diff. :/

shaneonabike’s picture

shaneonabike commented
Status: Active » Needs review
Dave Cohen’s picture

Dave Cohen commented
StatusFileSize
new fb_progress.diff1.23 KB

That didn't look great in chrome. Also doesn't do the right thing with fb_connected AND fb_not_connected.

I wasted some (more) time on this and came up with the attached patch. Have only tested on Chrome, but I think its an improvement.

Dave Cohen’s picture

Dave Cohen commented
Status: Needs review » Fixed

I went ahead and checked my patch #4 in. Please provide review and improvement if needed, even though I've marked fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.