This patch is a backport of http://drupal.org/node/128165 as per moshe's request.

CommentFileSizeAuthor
comment_db_rewrite_sql5.patch914 bytesjoshk

Comments

dww’s picture

dww
we/he/they
commented
Category: feature » bug

it's a bug if we're missing a db_rewrite_sql(), not a feature.

joshk’s picture

joshk commented

Thanks dww. :)

Any chance for a little code-review?

moshe weitzman’s picture

moshe weitzman commented

josh - we typically use same issue during a backport. after it gets committed to HEAD, we just set the version to the prior versio nand set to RTBC if a patch is in the issue.

joshk’s picture

joshk commented

Cool. I was not aware of that. I notice the status now, so makes sense.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Postponed

Waiting for the HEAD version.

mcarbone’s picture

mcarbone commented

FYI, the HEAD version has been committed. Should http://drupal.org/node/128165 be set to 5.x-dev or will the backport be handled in this thread?

Also, since this is a bug, should this get backported to 4.7 as well or do we just let sleeping dogs lie?

mcarbone’s picture

mcarbone commented
Status: Postponed » Needs review
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Closed (duplicate)

The code in http://drupal.org/node/128165 is better.