After a base installation of a clean working copy of COD and DP6, I get the following error messages:

warning: Invalid argument supplied for foreach() in /home/__/sites/__/sites/all/modules/cod_support/cod_session/cod_session.module on line 713.
warning: Invalid argument supplied for foreach() in /home/__/sites/__/sites/all/modules/cod_support/cod_session/cod_session.module on line 740.

Will revert shortly with a patch

CommentFileSizeAuthor
#1 cod_support-invalid_arguments_supplied_for_foreach-1478644-1.patch13.13 KBjcinteractive

Comments

jcinteractive’s picture

jcinteractive commented
StatusFileSize
new cod_support-invalid_arguments_supplied_for_foreach-1478644-1.patch13.13 KB

Attached is the patch for this issue

ezra-g’s picture

ezra-g commented

Thanks for the patch! This is likely to get reviewed during the DrupalCon Denver Distributions sprint.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Needs work

The patch includes some whitespace issues:

+    if( isset($days_slots) && !empty($days_slots) ) {

Should be:

+    if(isset($days_slots) && !empty($days_slots)) {

Can you run this through coder and re-post it?

ezra-g’s picture

ezra-g commented
Issue tags: +COD 6.x-1.0 radar

Tagging for 6.x-1.0 radar.

ezra-g’s picture

ezra-g commented
Status: Needs work » Closed (fixed) 
    if (!empty($days_slots)) {
      foreach ($days_slots as $day_key => $day_slots) {

It looks like some or all of these have been corrected, and the patch no longer applies - I'm not able to reproduce on a fresh install of COD beta 3. I'm marking as fixed but please re-open (ideally with an updated patch) if you're still seeing these errors.

ezra-g’s picture

ezra-g commented
Issue summary: View changes

Remove client details