I have drupal profile with this module as dependency. Whenever I finish install process, I get these errors:

No active batch.
Access denied. You must login to view this page.
Notice: Undefined index: query in _r4032login_destination() (line 124 of /var/www/www/sites/all/modules/contrib/r4032login/r4032login.module).

maybe You can set a simple isset() on line 124 for $query variable?

Thanks in advance,
Jānis

CommentFileSizeAuthor
#3 notice_undefined_index_query-1478800.patch1000 bytesJānis Bebrītis

Comments

Jānis Bebrītis’s picture

Jānis Bebrītis commented
Title: notice on line » Notice: Undefined index: query in _r4032login_destination() line 124

updated title

deekayen’s picture

deekayen commented

The quick workaround is to turn on clean URLs.

Jānis Bebrītis’s picture

Jānis Bebrītis commented
StatusFileSize
new notice_undefined_index_query-1478800.patch1000 bytes

wow, that was fast reaction :)
yup, noticed that right now while editing code. can You please review this patch and apply if it's good?

deekayen’s picture

deekayen commented
Status: Active » Needs work

Shouldn't $destination always have at least $path, even if $query is empty or am I missing enough context to understand.

Jānis Bebrītis’s picture

Jānis Bebrītis commented

good q, i see that everything inside { } brackets has been calculated from $destination['query'], including $path variable. So if $destination['query'] doesn't exist, $path doesn't exist either.

Slept < 4 hours tonight, don't take my word as final. Probably I am breaking whole module with this patch :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Closed (duplicate)

This code was removed in #1735762: Redirection not working on multi-lang site with prefixes so I guess the right status is "closed (duplicate)" although it's not exactly a duplicate.