Error when a content type is set to Never Protected

I quickly stumbled upon this issue after configuring the module. Here is a simple patch that should fix the issue. It makes the assumption that if $node->protected_node_is_protected is not set then the node type is configured to "never protected".

There was another notice when updating an existing node (unprotected content type). The new patch adds the same condition on the protected_node_node_update function.

Found one more issue when viewing a node from a "never protected" node type as anonymous. I've added a modification to a condition in the protected_node_is_locked function:

// before
if (!$node->protected_node_is_protected) {

// after
if (isset($node->protected_node_is_protected) == FALSE || !$node->protected_node_is_protected) {

testet patch #4 + looks good + so far no messages anymore ...
continue testing ...

thanks a lot ...

This also seems to fix an issue with importing nodes using the feeds module. I'd like to commit this, but I still have some questions/remarks about the patch.

+++ b/protected_node.moduleundefined
@@ -230,7 +230,7 @@ function protected_node_is_locked($nid, $op = 'access') {
+  if (isset($node->protected_node_is_protected) == FALSE || !$node->protected_node_is_protected) {

Is there a reason why not to use if (!isset($node->protected_node_is_protected) || !$node->protected_node_is_protected) instead?

Also, I see you use 2 "=" here, while in all other chunks of the patch you are using 3 "=". Is there any reason for this?

+++ b/protected_node.moduleundefined
@@ -410,6 +410,11 @@ function protected_node_node_load($node, $types) {
+  // The node type is never protected if $node->protected_node_is_protected is not set

Following the drupal code standards, Comments should start with a capital and end with a period (or a question mark). See http://drupal.org/node/1354.

Greetz,

Diederik

Hi, thanks for the review.

I think I've used the "== FALSE" instead of "!isset" since it's more explicit and more easily readable. The 3 "=" (strict equality) are not necessary since isset() will always return true or false.

Here is an updated patch. Let me know if you prefer that I change the "== FALSE" by the shorter "!isset" version, I can do that quickly if needed.

Committed. I decided to go for the !isset() since it's more commonly used and because it makes the code lines shorter (which also adds to readability).

http://drupalcode.org/project/protected_node.git/commit/4ad3d6e

Thanks for the good work on this!

Greetz,

Diederik

please have a look for:

http://drupal.org/node/1577682

Please don't mention unrelated issues, or if you think it is related at least explain why you think it is.

Thank you,

Diederik