14. In search_index() in case when $tag is FALSE variable $linktitle is undefined.
#1423460: [META] List of bugs and typos in Drupal core found by Spleshka

CommentFileSizeAuthor
#7 drupal-search_link_title-1479618-7.patch2.57 KB30equals
#2 drupal-search_link_title-1479618-2.patch2.58 KB30equals
search_link_title.patch2.06 KBdroplet

Comments

Status: Needs review » Needs work

The last submitted patch, search_link_title.patch, failed testing.

30equals’s picture

30equals commented
Status: Needs work » Needs review
StatusFileSize
new drupal-search_link_title-1479618-2.patch2.58 KB

Hiya,

i fixed the patch because it was failing tests. The reason it was failing was that '$linknid' was undefined. The previous patch had a new function which only returned the node->title, not the nid.

Hopefully testing will go well now.

droplet’s picture

droplet commented
Issue tags: -Needs backport to D7 
+++ b/core/modules/search/search.moduleundefined
@@ -782,6 +780,23 @@ function search_index($sid, $module, $text) {
+ *   Return node title. No return value if $path are not points to a node on this site.

little things needs fix :)

droplet’s picture

droplet commented
Issue tags: +Needs backport to D7

--

lars toomre’s picture

lars toomre commented

There also needs to be a blank line before the @return directive. Can we also add type hinting when this is re-rolled?

Status: Needs review » Needs work

The last submitted patch, drupal-search_link_title-1479618-2.patch, failed testing.

30equals’s picture

30equals commented
StatusFileSize
new drupal-search_link_title-1479618-7.patch2.57 KB

added blank line, and fixing the non object bug which failed the test.

30equals’s picture

30equals commented
Status: Needs work » Needs review

changing status.

Status: Needs review » Needs work

The last submitted patch, drupal-search_link_title-1479618-7.patch, failed testing.

30equals’s picture

30equals commented

failing again. i'll take a look it again asap!

internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

We are working today with this issue during Code Sprint UA.

internetdevels’s picture

internetdevels commented
Assigned: internetdevels » Unassigned

.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Closed (won't fix)

We are taking this functionality out of core Search indexing in
#2003482: Convert hook_search_info to plugin system
because it probably hasn't worked in ages and we didn't think it merited being in core Search any more, since core Search is trying to be much less node-specific.

droplet’s picture

droplet commented
Version: 8.x-dev » 7.x-dev
Status: Closed (won't fix) » Needs review

At least we need to disable the PHP warnings in D7.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

This is a duplicate of #1299530: php errors triggered during search indexing if content contains broken internal links which has a patch (just needs a test to be written).

droplet’s picture

droplet commented
Status: Closed (duplicate) » Needs work

It seems 2 issues fixing different bugs.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: -Needs backport to D7 +Needs tests

Oh sorry, I think you are correct. In any case... We need a test written for this issue, and it is 7.x only due to not indexing links in D8.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.