Extremely low priority patch, but I ran a Coder module review of this module's code to make sure a couple of patches I'd created passed muster and discovered a few minor issues: trailing spaces in a couple of files, an extra line at the end of another, a missing "an", and a capitalized "both" that didn't belong. The attached patch takes care of just those issues, though there are a couple of others that might warrant patches or even their own issue:
1) The guidelines over at the coding standards page suggest we should use Unix line endings; I'm not militant about that, except that some of this module's files use Unix line endings and others use Windows. We should standardize on one (I prefer Unix, but can handle either).
2) The module's admin page has a strange title, "Page Sort order," for the notification alerting settings. I don't think that title makes sense, though I'm happy to be proved wrong; I would propose something as simple as "Notifications" as a replacement title.
When generating my patches, I made sure to leave line endings alone, or we'd be seeing a diff in which every line is different.
| Comment | File | Size | Author |
|---|---|---|---|
| user_register_notify-grammar-code-review.patch | 4.64 KB | hackwater |
Comments
Comment #1
hass commented