Closed (fixed)
Project:
Learn
Version:
7.x-1.0-alpha3
Component:
User interface
Priority:
Major
Category:
Feature request
Assigned:
Reporter:
Created:
14 Mar 2012 at 14:40 UTC
Updated:
26 Aug 2012 at 14:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
bryanhirsch commented100% in agreement. Thanks for working on this TechNikh!
Comment #2
technikh commentedI am attaching the three features, full directories here
Comment #3
technikh commentedChanging status to Needs Review.
Comment #4
bryanhirsch commentedThanks Nikh! I'll take a look.
Comment #5
bryanhirsch commentedTechNikh, thanks. I think this is useful to make it easier for some other people to tinker with theming with CSS. I'm not sure this actually makes the flags more usable though. For future reference, please upload a patch, it makes code reviewing easier.
I went ahead and committed. I think this will provide a good starting point for sprinters at DrupalCon.
Comment #5.0
bryanhirsch commentedclarify problem and solution
Comment #6
bryanhirsch commentedchanging status
Comment #7
bhosmer commentedAssigned to bhosmer
Comment #8
bhosmer commentedI haven't had a chance to create a patch yet, and the repository contains some binaries as well that I don't think will transfer with a patch.
https://github.com/benhosmer/Learn
I hope in the next few days to also add a pre-process to the .module to circumvent the shifting image when the user rolls over it.
Comment #9
bryanhirsch commentedWe're making great progress. Building on top of @TechNikh's improvements with these icons is awesome, @bhosmer and @brightbold. It looks like the checkbox icon is getting cut off in some places.
https://skitch.com/bryan.hirsch/8q2bi/drupal-ladder-ld.dev
https://skitch.com/bryan.hirsch/8q2b5/install-git-ld.dev
If you make the height of the icon bigger, it seems to break the ladder. But I believe this can be fixed pretty easily by increasing the height of the ladder rungs in the Ladder module CSS (I went ahead and did this quickly, see ec9804a, but now we should probably adjust a few other things on the ladder, like the positioning and/or size of the lesson title text, to make it look right).
It would also be awesome if we could come up with similar icons for bookmarked and recommended. (brighbold suggested a bookmark icon and a star during our sprint at DrupalCon Denver. These sound like terrific ideas to me.)
Comment #10
bhosmer commentedThanks Bryan. I haven't had a chance to work on the images getting cut off yet, this was my idea for implementing the pre-process function. When the user hovers over the link, the text that is supplied by the flag module changes. This is causing the image to shift.
Let me see what I can come up with.
Comment #11
brightboldJust wanted to confirm that I do intend to contribute additional icons and add some hover styles, but I haven't had a chance to do it yet. I'll take on the CSS issues with the ladder too (I thought we'd fixed some of those in Denver, but obviously not!) if Ben doesn't beat me to it.
Comment #12
bryanhirsch commentedAwesome. Thanks @BrightBold.
When you get back to it, you may want to take a look at this thread just to see if there's any progress on a larger color scheme or site design to coordinate with: http://drupal.org/node/1504476#comment-5830124.
Comment #13
bryanhirsch commentedPatches in Ben's GitHub repo committed and released with Lessons 7.x-1.0-alpha8 and Ladder 7.x-1.0-alpha3.
Comment #14.0
(not verified) commentedadd DONE item for step nikh completed