Hi there,

I just wanted to add this little feature request:

When the smileys are selected from the database and shown in the smileys table, they show up multiple times, when they have more than one substitution string. Is it possible to distinct select the smileys files when shown on the smileys table?

It is really cool to add several substitution strings for backwards compatibility with older texts, where these may show up, but for adding smileys to new texts, it should be fine to show only one smiley with one substitution string.

Thanx in advance & cheers

hctom

Comments

hctom’s picture

hctom
Primary language German
commented

just a little follow up:

for a quick workaround i customized the theme-function to push all shown image files to an array and check the upcoming files, if they are already in that array:

function theme_smileys_select_table() 
	{
	drupal_add_js(drupal_get_path('module', 'smileys') .'/smileys.js');
	drupal_add_css(drupal_get_path('module', 'smileys') .'/smileys.css');
	$content .= '<div id="smileys">';
	$list = _smileys_list();
	$smileys_already_shown = array();
	foreach ($list as $smiley) 
	{
		if(!in_array($smiley->image, $smileys_already_shown))
		{
			$acronyms = explode(' ', $smiley->acronyms);
			$alt = check_plain(implode('  ', $acronyms));
			$desc = implode('&nbsp; ', $acronyms);
			$content .= '<span><img src="'. check_url(base_path() . $smiley->image) .'" title="'. check_plain($smiley->description) .'" alt="'. $acronyms[0] .'" class="smiley-class"/></span>';
			array_push($smileys_already_shown, $smiley->image);
		}
		
	}
	$content .= '</div>';
	return $content;
}
Gurpartap Singh’s picture

Gurpartap Singh commented
Status: Active » Closed (won't fix)

If you set all acronyms together(separated by a space) for single image entry, you won't encounter that problem.