Hi! Webform is super! Perhaps someone has already asked this, I don't know. I need to be able to change submissions made via Webform, e.g. a spelling mistake in a name, or a radio box choice. Are there plans for that? Is it possible now. Thanks!

CommentFileSizeAuthor
#25 webform_submission_edit.patch18.39 KBaj_drupal
#14 webform_18.patch372.68 KBgvdvenis
#9 webform_17.patch17.79 KBgvdvenis
#7 webform_16.patch9.25 KBgvdvenis

Comments

gvdvenis’s picture

gvdvenis commented

I Also DESPERATELY need this functionality. I tried to patch it myself, but this seems a daunting task, in which i didn't succeeded (yet). So PLEASE someone.. take a stab at this one...
Maybe someone already has this functionality built in their webform module.. please let me know how to crack this nut...

quicksketch’s picture

quicksketch
he/him
commented

I'm not planning on implementing this functionality into webform. Any patches to add it will be accepted.

gvdvenis’s picture

gvdvenis commented

OK, But how on earth do i do this? I just don't know where to start. Maybe you can point me in the right direction. Which files/modules do i need to patch to get this working. I browsed through all the webform module files, but it seems that disabling the form fields is done somewhere in the formapi and thus probably is the standard behaviour for form viewing. Can you confirm this conclusion and maybe give me a hint where i should start? Any help is greatly appreciated. Thanks in advance and regards,

Gert v.d. Venis

gvdvenis’s picture

gvdvenis commented

Ok i just succeeded in having this done.Only i'm stuck with an old version.
I'm willing to provide a patch, but how to do this?

quicksketch’s picture

quicksketch
he/him
commented

Check out the handbook page on creating patches. You'll need to download a clean copy of the version you modified, then make a diff between them. If you post the patch here I'll try to apply it to the latest version.

http://drupal.org/patch/create

quicksketch’s picture

quicksketch
he/him
commented

Marked http://drupal.org/node/152439 as duplicate.

gvdvenis’s picture

gvdvenis commented
Version: 5.x-1.3 » 5.x-1.4
Component: Miscellaneous » Code
Assigned: Unassigned » gvdvenis
Status: Active » Needs review
StatusFileSize
new webform_16.patch9.25 KB

Ok here is a patch. It contains changes to be made in several files. There are, however, some minor enhancements that need to be done: these include:

- customizing the confirmation message after updating an existing submission.
- After updating a submission the "go back to form" should really be "go back to submissions"
- Translation files need to be updated
- Maybe some other things you can think of...

Hope this helps.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work

These changes look pretty good. Could you reroll the patch with the -u option to make it a unified patch? Also, webform_edit() is not a good name for the edit-submission function as Drupal will think that it is an instance of hook_edit(). Use something more specific like webform_submission_edit().

gvdvenis’s picture

gvdvenis commented
Status: Needs work » Needs review
StatusFileSize
new webform_17.patch17.79 KB

Ok thanks for your suggestion, i changed the function name as proposed, and made a unified patch. Sorry about that faulty patch i'm new to this stuf. I left the default context set to 3; I have no idea what this means, but i hope it'll do the job this time... Regards,

Gert

P.S. the todo's remain, see my previous post for details.

dolittle’s picture

dolittle commented
Title: changing form submissions » Need help to apply the patch

Can you explain please how to apply and test the patch?
I have installed cygwin on my local machine.
This is my first attempt to apply a patch and I get allot of alerts in cygwin.
Should I put the patch file in the webform folder and run the command from shell?
Do I need to apply it to the dev or stable version?

Any help will be appreciated.

dolittle’s picture

dolittle commented
Title: Need help to apply the patch » changing form submissions

I accidentally changed the issue titile so changed it back.
Sorry

quicksketch’s picture

quicksketch
he/him
commented

@gvdvenis Thank so much! I'll review the patch when I have time and look at putting it in.

@dolittle http://drupal.org/patch/apply

gvdvenis’s picture

gvdvenis commented

@ Dolittle:
First of all you should read the documentation on this subject these locations:
- http://drupal.org/patch (General information concerning patches)
- http://drupal.org/patch/apply (Specific information on applying patches)
- http://drupal.org/node/32875 (Probably what you want to look as, as it describes how to apply patches with cygwin)
Hope this helps you out, if not, let me know. Regards

Gert

gvdvenis’s picture

gvdvenis commented
StatusFileSize
new webform_18.patch372.68 KB

Sorry for the inconveinience, but it seems that the patch was corrupt. I'll hereby put up the good one.
The patch originates from the last stable version. So here is what you should do (or how i got this done).

  1. Extract the stable version into a folder: lets say d:\webform
  2. Put the webform.patch and the patch.exe also in there.
  3. Run cmd and change to the d:\webform directory
  4. Run the patch command: patch -p0 -u < webform.patch
  5. Finished!

Hope this helps...

chrizz’s picture

chrizz commented

this patch is great! it works most of the times. The times that i use a page break is one of those times it doesn't work.
When I want to edit a multipage form submission the whole form is presented. The form can't be submitted because there is no submit button but a next page button instead.

gvdvenis’s picture

gvdvenis commented

sorry for the late reply, but i promise that i'll have a look at it as soon as i find the time for it. If you want to have a go at thisone, please do... if not... well then i'll fix it sooner or later... Regards,

Gert

chrizz’s picture

chrizz commented

Hi Gert, Here is also a little late reaction.
I'd like to give it a try but i don't know where to start. What do you think is going wrong and where do i have to start fixing this problem? thanks in advance.

Anonymous’s picture

Anonymous (not verified) commented

I have implemented the patch, but I've noticed that you can't seem to edit hidden fields. They show up fine and the text can be changed in the box, but it doesn't appear to post properly to the database. Any idea where to look to fix this?

Anonymous’s picture

Anonymous (not verified) commented

OK. I got it. Hidden field values were hard-coded. (In the form, it was using '#value' instead of '#default_value'.) Changed the following two functions:

function _webform_render_hidden($component) {
  $form_item = array(
    '#type'          => 'hidden',
    '#default_value'          => _webform_filtervalues($component['value']),  // was '#value' in original release
    '#weight'        => $component['weight'],
  );
  
  return $form_item;
}

function _webform_submission_display_hidden($data, $component, $enabled) {
  $form_item = _webform_render_hidden($component);
  $form_item['#default_value']         = $data['value']['0'];   // was $form_item['#value'] in original release
  $form_item['#type']          = 'textfield';
  $form_item['#title']         = htmlspecialchars($component['name'], ENT_QUOTES) ." (hidden)";
  $form_item['#disabled'] = !$enabled;
  return $form_item;
}

This allows Drupal to use the POSTed value instead of the default value. Appears to work fine - no side effects noted yet - doesn't break existing functionality.

Cheers!

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Needs work

The patches submitted still aren't usable. But since this issue was posted we got some sweet docs on making patches: http://drupal.org/patch/create

Anyone wanting to try a re-roll, I definitely encourage them.

gvdvenis’s picture

gvdvenis commented

I Don't understand... It works fine for me! Which version are you patching from?

gvdvenis’s picture

gvdvenis commented
Title: changing form submissions » How is this possible?

This is strange! This seems to be another patch then i submitted! I used this one quite some time ago and it worked back then! now it seems to be altered/overwritten... I'll look into it

quicksketch’s picture

quicksketch
he/him
commented
Title: How is this possible? » Changing form submissions

The patch actually replaces nearly all the code in all the .inc files, causing conflicts anywhere where a single line has been changed. The patch needs to apply against the latest CVS in the DRUPAL-5 branch.

kbm065’s picture

kbm065 commented

Will anyone make a patch that will work? It's clearly that many people want this function.

aj_drupal’s picture

aj_drupal commented
Status: Needs work » Needs review
StatusFileSize
new webform_submission_edit.patch18.39 KB

Here is the modified version of the patch submitted by gvdvenis. This works with multipage forms also.

quicksketch’s picture

quicksketch
he/him
commented

Thanks aj_drupal! I'll have a look at it the next time I run through the webform issue queue.

gvdvenis’s picture

gvdvenis commented

I'm very sorry i wasn't able to get the work done. Firs of all my pc crashed, and i lost all data related to my last (6 months) of drupal work... Apart from that i became the father of a beautifull daughter wich i am VERY proud of. Also as a result of that there isn't very much time left besides my other activities to keep working on this. I Want to thank aj_drupal for his effort to breeth new life into this issue and hope to find some time to review it... till then: keep up the good work guys! Regards,

Gert

mailleux’s picture

mailleux commented

I tried the patch, with a limit of one submit per user (ever). And I get the edit form, but can't update the values because the user exceeds the limit. Even though he is updating an existing submission. Is that the intended result?

quicksketch’s picture

quicksketch
he/him
commented
Version: 5.x-1.4 » 5.x-1.7
Status: Needs review » Fixed

I gave this patch a review and testing. Like mailleux mentioned, it wasn't possible to edit a submission if you were already at your submission limit. I added a condition for editing that prevents the check, and also prevents another email being sent to the webform email address when a submission is edited.

This looks real sharp. Because I'm going to be hitting the queue real hard the next few days and don't want the patch to go stale, I went ahead and committed to the 5.x branch. Thank you so much to gvdvenis and aj_drupal!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

gvdvenis’s picture

gvdvenis commented
Version: 5.x-1.7 » 6.x-2.x-dev
Status: Closed (fixed) » Active

Any change this can be ported to the 6.x version too?

quicksketch’s picture

quicksketch
he/him
commented
Version: 6.x-2.x-dev » 5.x-1.x-dev
Assigned: gvdvenis » Unassigned
Status: Active » Closed (fixed)

This is already in the 6.x version. The Webform 2.0 version is identical between 5 and 6, other than the pagebreak functionality isn't working yet in 6.x. Please open a new ticket for any questions on this issue and leave this one closed.