When I am editing a box directly on a page, I get the "popup" dialog to edit the box. If I click "Cancel" it closes as expected, however, if I click the "X" close button on the dialog, the content under the popup does not display.

CommentFileSizeAuthor
#6 boxes-fix-wysiwyg-detach-1482476-6.patch1.2 KBjec006
#5 boxes-fix-wysiwyg-detach.patch1.21 KBjec006
#2 boxes-close-1482476-2.patch1.03 KBjec006
#1 boxes-close-1482476-1.patch594 bytesbrenk28

Comments

brenk28’s picture

brenk28 commented
StatusFileSize
new boxes-close-1482476-1.patch594 bytes

This patch simply replicates the cancel button action.

I did notice some unexpected behavior whilst testing. For instance, without this page, if I tried to edit the same place twice, the first time I would get the "popup" whereas the second time it would be inline. And the second time ckeditor js throws an error and doesn't render. It seems to happen as well if I edit different blocks on the same page. With the patch, I still have most of this, though the second time I edit the same block, it still with the popup editor, though you can see the inline editor underneath.

So, this patch doesn't address those other items, need to dig into a bit more to figure those out.

jec006’s picture

jec006 commented
Status: Active » Needs review
StatusFileSize
new boxes-close-1482476-2.patch1.03 KB

Updated patch to fix the inline editor problems and some js problems.

tirdadc’s picture

tirdadc commented
Status: Needs review » Fixed

The patch in #2 fixes the original issue and behaves consistently. Tested and committed, thanks!

tirdadc’s picture

tirdadc commented
Status: Fixed » Needs work

While this does work with regular boxes and views boxes, it gets stuck in 'loading...' mode with entity boxes. Will need to investigate a bit.

jec006’s picture

jec006 commented
StatusFileSize
new boxes-fix-wysiwyg-detach.patch1.21 KB

This also doesn't address detaching the wysiwyg - this will cause issues if you try to edit a box 2 times in a row

Here is a patch to fix that issue

jec006’s picture

jec006 commented
StatusFileSize
new boxes-fix-wysiwyg-detach-1482476-6.patch1.2 KB

And one without the whitespace error

tirdadc’s picture

tirdadc commented

This does fix the bug that led to the '[CKEDITOR.editor] The instance "edit-body-value" already exists.' when calling method: [nsIDOMEventListener::handleEvent] error message due to the WYSIWYG not getting properly detached before. Committed.

jec006’s picture

jec006 commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.