Once #919224: Allow use of subtrees or individual file from archives instead of the whole archive lands in Drush core, we're going to want to allow this attribute for d.o packaging to solve the kinds of problems described at #1481158: how to deal with problem third party libraries?. This is blocked on #919224 but I wanted to open an issue about it so we don't forget and so interested parties can follow this to track progress.

CommentFileSizeAuthor
#4 1482888-4.subtree.patch672 bytesdww

Comments

bonobo’s picture

bonobo commented

Let us know if/how we can help on this.

dww’s picture

dww
we/he/they
commented

It's the other issue. This is about a 9 byte change to a validation function to add 'subtree' to an array of allowed values, and some documentation edits. ;) getting the feature itself in drush with solid tests is where to help.

Thanks!
-Derek

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Postponed » Active

The other issue was resolved today.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 1482888-4.subtree.patch672 bytes

Sweet! That was fast. ;)

In that case, here'a s patch. Untested, but probably all we need. I don't think we need a test for this here if the feature itself is working in drush -- just ensuring the attribute whitelist works for this keyword is probably overkill (although if someone wants to add a test I certainly won't stop them).

jgraham’s picture

jgraham commented

Patch applies cleanly and looks safe. Drush itself already has tests to cover the new feature and I agree a test to check the whitelist works seems overkill.

What can I help with to get this on d.o?

dww’s picture

dww
we/he/they
commented

You could apply the patch and manually test building a .make file that uses this feature with the --drupal-org option set and make sure it actually works.

Thanks,
-Derek

jgraham’s picture

jgraham commented
Status: Needs review » Postponed

It looks like something happened in the commit for drush. It's no longer working compared to the patch I tested. I will follow up in the drush queue and get that resolved there first.

jgraham’s picture

jgraham commented

related drush issue #1514120: subtree option no longer works

jgraham’s picture

jgraham commented

#1514120: subtree option no longer works is resolved.

Using the drupal-org makefile from julio with;
drush make --drupal-org drupal-org.make /tmp/maketest0

Results in the expected directory structure for the libraries.

jgraham’s picture

jgraham commented

We may want to wait for #1515418: more robust test for subtree before adding this on d.o.

Leaving this as postponed for now I'll leave that to the discretion of dww or jhedstrom, although I would say RTBC since #1514120: subtree option no longer works has gone through and tests okay in both the drush tests and explicit tests against julio.

jgraham’s picture

jgraham commented
Status: Postponed » Active

Changing to active so this gets back on the radar.

Edit: But I think this is RTBC

jgraham’s picture

jgraham commented
Status: Active » Reviewed & tested by the community

jhedstrom just committed the patch for #1515418: more robust test for subtree

This looks good to go.

jgraham’s picture

jgraham commented

It looks like this is live on drupal.org drush, can we close this out?

Edit: To clarify the fullcalendar and nivoslider libraries for julio are being modified as per our subtree directive. So this appears to be on drupal.org's build stack.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Postponed

Wow, #13 is scary. No, this hasn't been committed, much less deployed. However, this reveals a major bug:
#2012084: drupalorg drush not enforcing certain constraints on libraries, only projects

Whoops! At least the good news is the fact this hasn't been committed and deployed isn't blocking your progress... ;)

AubreyR’s picture

AubreyR commented
Version: » 7.x-1.x-dev
Issue summary: View changes

Bump. Is this actually fixed or still postponed?