Closed (outdated)
Project:
Taxonomy Menu
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2012 at 02:38 UTC
Updated:
18 Mar 2026 at 13:38 UTC
Jump to comment: Most recent
Comments
Comment #1
rondev commentedI added a test and an output to the watchdog to help to remove bad menu entries:
PS: Although I may propose working code, I consider myself as a newbie concerning php and drupal api.
The problem with that solution is that it adds watchdog entry when rebuilding menu too for each valid terms. We should have a more sophisticated test to see if the menu entry is a valid term. Per example with
if (_taxonomy_menu_get_tid($item['mlid']))Comment #2
rondev commentedI cite myself because I studied more in deep the _taxonomy_menu_delete_all function.
It deletes only terms of the taxonomy, not menu entries that are not terms that may have been added sooner or later. I consider myself that as a good and safe behavior.
The watchdog entry I added in the proposed code to taxonomy_menu_translated_menu_link_alter should help the site maintainer to let, move or remove the menu entry which is in a menu dedicated to taxonomy terms. It seems a good way to solve the issue.
Comment #3
dstolHey, welcome to Drupal and thanks for the patch! http://drupalcode.org/project/taxonomy_menu.git/commit/333323c
Comment #4
dstolSee #1496192: Latest dev breaks multi language taxonomy menu
Comment #5
rondev commentedI don't think my modification generate the issue #1496192: Latest dev breaks multi language taxonomy menu.
I'm not sure. I just test if $t is valid.
Before, if $t was not valid there was an error and the code was not executed.
Founded nothing wrong using a debugger.
Comment #6
johnvComment #8
vladimirausThank you for your contributions.
Drupal 7 is no longer supported.
Closing this issue as outdated.