Don't redirect to Orders after deleting a Shopping Cart Order

Agreed. This has annoyed me, too. I wonder if we can do it simply through Views by adding a destination parameter to the delete link. I'm not sure if that's possible, but it's the first thing to investigate.

Adding a destination to the query string will indeed resolve this issue, similar to how this issue was solved for products in #1128734: Redirect Product operations links back to the main View.

Since adding this code to the order operations field handler would duplicate the code from the product operations field handler, and since a lot of the "operations field" code is shared between customer/product/order/..., I moved the shared code into a new base class, commerce_handler_field_operation.

Child classes of commerce_handler_field_operation implement the get_operation_links function to return the operations they want to show.

upload failed for some reason, re-attaching the patch.

• Fixes the test failure (links with destination query parameter did not match the expected order operation links)
• Also makes the "cancel" links return to the origin page instead of the hard-coded admin/commerce/[orders|products|customer-profile] if destination is given and not external.

#5: 1483056-operations-field-redirect-5.patch queued for re-testing.

Requesting a re-test since none of these failures occur during local testing.

Ok, my bad, forgot to include one file in the previous patches causing the failures...

Out of curiosity, how would this patch affect people who have already customized the various Views that include operations links? Would the existing links still work as they did before, or is there something special in the update that would require them to be updated manually for already altered Views?

The only way this will affect custom views is that the operations field for Orders, Payments and Products will get an additional option ("Add destination query parameters …"), which is not set by default.

So these customized views would not automatically be changed by this patch, which I assumed is preferred?

Actually, I needed to double-check that the option actually exists to prevent undefined errors. For some reason these errors didn't occur when I first tested this scenario.

forgot a file...

Working for me, thanks.

One gotcha is that when ticked in the context of one view (admin/commerce/orders/carts) there's also a destination parameter added to operations in other views (admin/commerce/products, admin/commerce/file-licenses).

[Edit: On checking a second site, I see destination is already present on products and licenses views.]

Um, considering that "Add a destination parameter ..." options is already there for "Commerce Order: Operations links", this simple patch should be enough now.

Heh, yeah, somewhere along the way I added the destination option to the order operations handler (likely from a separate issue) without updating this issue. Still, mr.baileys's patch goes further in that it abstracts our operations link handlers a bit and updates the "Cancel" link on delete forms to use an existing destination parameter if available so they go back to the right place. It likely needs a re-roll now, though.