drupalmt

welcome,

I think the .info is not necessary.

Is this drupal-version specific?
If yes:

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

I wonder how to handle bash scripts in the application queue :o
Are there coding standarts? Can we accept bash scripts for applications?
Maybe another admin could enlight this ;)

regards

Assigning to @klausi,

I know you got quite an experience with bash scripts, would you mind having a look on this one? ;)

Added http://git.drupal.org/sandbox/david.mckay/1483558.git

Auto-review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...ww/drupal7/sites/all/modules/pareview_temp/test_candidate/drupalmt.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 1 | ERROR | "description" property is missing in the info file
 1 | ERROR | "core" property is missing in the info file
--------------------------------------------------------------------------------

@ luxpaparazzi
please read the discussion above before you just post automated reviews in here.
this is no module, this is a version independent bash-script

1. you are using TABs in your script, they should be replaced by 2 spaces each.

2. as shell scripts are hard to read I suggest adding more comments

3. Display an warning message => Display a warning message

4. I would not call the script "drupal" as any module could be named that way, and it does not give much info about the script itself

5. shouldn't the file have an extension .sh?

---
The response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826

You could for example start by evaluating my own project:
http://drupal.org/node/1302786

@patrickd : you are correct, I did not pay attention on the "version-independent" nature

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

http://git.drupal.org/sandbox/david.mckay/1483558.git