hi,
Ported this module to D7. please review it .
cheers

CommentFileSizeAuthor
#8 user_visits_adv_1484132_amitgoyal_d7.patch8.85 KBamitgoyal
#1 user_visits_adv.patch14.32 KBnit3ch
user_visits_adv.patch12.11 KBnit3ch

Comments

nit3ch’s picture

nit3ch commented
Issue tags: -D7 port patch +New patch
StatusFileSize
new user_visits_adv.patch14.32 KB

Sorrry by mistake i attached wrong patch . here is the tested patch and it is working fine on my set up.
cheers

toemaz’s picture

toemaz commented

Hey nit3ch,

Can I make you co-maintainer of this module? I don't have time to follow up on this one.

toemaz’s picture

toemaz commented

I made you co-maintainer. Welcome on board, don't screw anything up ;)

nit3ch’s picture

nit3ch commented

many many thanks toemaz

nmudgal’s picture

nmudgal commented
Status: Active » Needs work

Hi,

  • Just after applying patch, it threw a warning.
    warning: 2 lines add whitespace errors.
  • Another thing I noticed in patch is you are missing space, you should put one blank line after function '}' closing tag & next function documentation.
  • As soon as I enabled the block, got these errors:
    Notice: Undefined index: visitors in user_visits_adv_get() (line 166 of /Applications/MAMP/htdocs/score/trunk/drupal7/sites/all/modules/user_visits_adv/user_visits_adv.module).
Notice: Undefined variable: output in user_visits_adv_visitors_block() (line 98 of /Applications/MAMP/htdocs/score/trunk/drupal7/sites/all/modules/user_visits_adv/user_visits_adv.module).
Notice: Undefined index: total in user_visits_adv_get() (line 166 of /Applications/MAMP/htdocs/score/trunk/drupal7/sites/all/modules/user_visits_adv/user_visits_adv.module).
Notice: Undefined index: history in user_visits_adv_get() (line 166 of /Applications/MAMP/htdocs/score/trunk/drupal7/sites/all/modules/user_visits_adv/user_visits_adv.module).

Thanks

nit3ch’s picture

nit3ch commented

hi nmudgal
since this module id dependent on user_visits module so we are getting the followin notices but the module must be working.i will soon rectify these notices and will apply a path.
thanks

crazyrohila’s picture

crazyrohila commented

hmm I think basically module is working fine but Needs some minor fixes .

amitgoyal’s picture

amitgoyal commented
Status: Needs work » Needs review
StatusFileSize
new user_visits_adv_1484132_amitgoyal_d7.patch8.85 KB

@nit3ch - Please find attached updated patch which fixes all the errors reported by coder module along with errors reported by @nmudgal.

Few more changes to make d7 version work. I will really appriciate if you can please review and apply this patch and release the D7 version of this module. Please note that this patch needs to be applied on 7.x-1.x branch.

toemaz’s picture

toemaz commented

@amitgoyal clean patch! You have co-maintainership now. Good luck.

sanchi.girotra’s picture

sanchi.girotra commented
Status: Needs review » Reviewed & tested by the community

@amitgoyal - I have tested this patch and it worked as required.

amitgoyal’s picture

amitgoyal commented
Assigned: Unassigned » amitgoyal
Status: Reviewed & tested by the community » Fixed

Thanks @sanchi.girotra for reviewing and testing the patch.

Finally we have released User Visits Advanced module for Drupal 7.x!

Automatically closed -- issue fixed for 2 weeks with no activity.