Running my site through the W3C Validator, I get only one error on my page:
name start character invalid: only S separators and TAGC allowed here.
<div class="item-list"><ul id="account-menu" class="mini-menu menu account anon"><li><a href="/user/login?destination=node">login</a></li><li><a href="/user/register?destination=node">register</a></li></ul id="account-menu" class="mini-menu menu account anon"></div> </div>
I just had to make some patches to the signwriter code to pass Strict validation, but I'm stumped on how your module code is outputting this XHTML. I haven't messed with blocks as much, so I'm not sure what's going on here.
As you can see in the code, your module is passing the id and class attributes to the closing /ul tag, which is illegal.
I'd love to learn how your code is outputting the XHTML and fix this myself if you want to point me in the right direction. Thanks for a fantastic module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | minimenus_itemlist_fix.patch | 1.16 KB | chirale |
| #3 | minimenus_itemlist.patch | 1.16 KB | chirale |
Comments
Comment #1
robin monks commentedThat's because the attributes are being sent as additions to the the theme('list'...function. I believe there is a better way to do this in 5 that will make valid XHTML 1.1. I'll get this fixed this weekend, but feel free to jump in with a patch :)
Robin
Comment #2
jiangxijay commentedWhen will this be taken care of? I see that the problem still exists at CivicSpace ...
Comment #3
chirale commentedAccording to includes/theme.inc/5/source :
theme_item_list($items = array(), $title = NULL, $type = 'ul', $attributes = NULL)Type and attribute must be separated, and attributes argument is an array.
Here's the patch.
Comment #4
chirale commentedSorry, a small fix (class "anon"). Here's the right patch.
Comment #5
robin monks commentedDevelopment of MiniMenus has ceased. See the module page for a list of other similar modules that provide this functionality in Drupal 6 forward.