Comments

markwk’s picture

Glad to see this has started. I've been checking this project off and on for a D7 port. Post when you are ready for testing.

darrell_ulm’s picture

Hi, I am getting close. There are some database calls to convert to the D7 api methods and then it ought to be working.

darrell_ulm’s picture

Category: Feature request » Task
Priority: Critical » Major
Issue summary: View changes

Back to looking at this one again.

  • quantumtime committed df325b6 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Fixed menus for content type, and...

  • quantumtime committed 3453bea on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Fixed node links section, started working...
  • quantumtime committed e47a48d on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Start resolving bugs, code clean up.
    

  • quantumtime committed 6a7b975 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Update more permissions - fix errors due...

  • quantumtime committed 7c6b194 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: fix sql call for function...

  • quantumtime committed 2112f42 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: fix some theme issues with reports.
    

  • quantumtime committed be56844 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Updated admin hook_menu items to D7...

  • quantumtime committed 64ffe03 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Fix admin path and set @TODO on some...

  • quantumtime committed a29452e on 7.x-1.x-dev
    Issue #1484470 by quantumtime: typos in sql statements prevented page...
darrell_ulm’s picture

Issue tags: +7x upgrade

More progress, although not enough to make a 7.x-1.x release quite yet. Thinking it will be easier to incorporate some of the enhancements people are looking for in the 6.x version in Drupal 7.

Want to have a dev release soon for testing.

  • quantumtime committed 8f76b3f on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Add @TODO notes and fix formatting.
    

  • quantumtime committed bc5c1ca on 7.x-1.x-dev
    Issue #1484470 by quantumtime: replace a ['q'] for a request_path.
    

  • quantumtime committed 2bf9021 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Start working on theme layer chnages and...

  • quantumtime committed 5f083ba on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Fix more items abuse.report.tpl.
    

  • quantumtime committed 98d12d2 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: More style updates, add @TODOs. Still...
umtj’s picture

StatusFileSize
new49.19 KB

I'v been working on this patch for a couple of days.

The patch includes:
- Loading of user account in _abuse_load. Include it in the object. This changes templates too.
- A lot of markup changes in templates.
- Changed it to use entities instead of nodes, comments and users.
- Forms changed to D7.
- Removed $flagger, $admin, $suerpadmin and $configure from hook_menu. Way better reading this way.
- Reviewed SQL queries.
- Rewrote much of _abuse_load function.
- Cleanup of comment function.

I think that's about it. Let me know if i'm on the right track!

darrell_ulm’s picture

Hey thanks,

Assuming this is meant to apply against the dev branch, and I want to do a review of the code before adding it of course.

Thanks again.

  • quantumtime committed 4089d1e on 7.x-1.x-dev authored by umtj
    Issue #1484470 by umtj,quantumtime: Massive patch, entity, _abuse_load...
darrell_ulm’s picture

In general it's improved, many improvements.

These paths do not work now, but there were issues with them prior and in general looks like it's headed in the right direction.

Paths:
admin/abuse/status/node/node#
abuse/report/node/node#

So, getting there, but still more to do. Thanks again for the patch, and gave you the author credit obviously.

darrell_ulm’s picture

Actually it works better that I thought. Added entity module dependancy, and things work better now. :)

  • quantumtime committed d7d0166 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: [Short Comment flag database fix, other...

  • quantumtime committed db32885 on 7.x-1.x-dev
    Issue #1484470 by quantumtime: Fix comment sql call, some tpl issues.
    
umtj’s picture

quantumtime committed d7d0166 on 7.x-1.x-dev, why the $user = $GLOBAL['user']?
quantumtime committed db32885 on 7.x-1.x-dev, in template why not use render?

umtj’s picture

StatusFileSize
new9.32 KB

A colleague of mine made a lot of changes to templates.

Here's a patch for the templates.

He's username is: martinyde.

darrell_ulm’s picture

@umtj, thank you. Can he/she submit the patch her/him self? If added, who shall I give credit.

Also, the whole thing needs a complete code review before we make any type of release.

umtj’s picture

He cannot at the moment. That's why I posted it. But the correct username should be 'martinyde'.

I agree! A codereview is very much needed.

darrell_ulm’s picture

@umtj, Intend to incorporate this soon, and thanks!

umtj’s picture

StatusFileSize
new515 bytes

Small patch removing hook_user_access(). Not sure what it's for.

darrell_ulm’s picture

Hi @umtj, agreed we need to evaluate some of the D6 to D7 changes and see what is still needed or not, as well as really test security with a fine toothed comb.

Right now I'm a bit busy with some work I absolutely need to get done this week, but we can take a look at these patches soon.

Thank you for again your input @umtj!

umtj’s picture

StatusFileSize
new2.49 KB

Updated user_access patch!

umtj’s picture

StatusFileSize
new3.21 KB

Forget about user_access2.patch, use user_access3.patch please.

umtj’s picture

StatusFileSize
new707 bytes

Sorry about this. This patch should be final for user_access.

umtj’s picture

StatusFileSize
new2.83 KB

_abuse_get_assigned_count function updated with correct usage of db_or. groupBy and range is not supported in db_update funciton.

This is really messy. I'll need some help here!

umtj’s picture

StatusFileSize
new958 bytes

Small bugfixing, enjoy!

umtj’s picture

StatusFileSize
new1.16 KB

Sorry, last patch had an issue.

darrell_ulm’s picture

Thanks, @umtj.

Questions to save time:

  • Will these patches apply in order?
  • Is there any way to wrap them into 1 patch?

Thank you!

umtj’s picture

StatusFileSize
new615 bytes

Here's a patch for taxonomy in abuse_entity_view.

Will these patches apply in order? Yes
Is there any way to wrap them into 1 patch? I could but why another file?

umtj’s picture

StatusFileSize
new15.95 KB

Here's a fully patch.

umtj’s picture

StatusFileSize
new1.47 KB

Comment table corrected. Full patch.

umtj’s picture

StatusFileSize
new97.78 KB

So here a new patch. This one should be full and with a lot of changes in code, style and comments.

umtj’s picture

StatusFileSize
new101.83 KB

Guess i cleaned a bit too much up. Here's a version with working tabs and a little bug fixing in abuse.admin.inc.

umtj’s picture

StatusFileSize
new104.4 KB

allow/remove functions updated

darrell_ulm’s picture

@umtj Large patch. I'll try to get some time to look at it over the long weekend.

umtj’s picture

@quantumtime do you need any help?

darrell_ulm’s picture

Hi @umtk, this module is an experimental upgrade for me, just for fun, and I've been onto some non-Drupal IT projects recently, my short break will not last.

You can ask @BTMash to make you a co-developer on this and you should be able to make your own commits, if you feel comfortable doing so.

darrell_ulm’s picture

@umtj Pretty sure you'll need to ask @BTMash to give you permissions instead of me. Thanks again.

btmash’s picture

Sorry, I was not subscribed to this issue and just saw it now. I made @umtj a maintainer so you can both work on the 7.x version.

darrell_ulm’s picture

Thank you @BTMash, the large patch of @umtj could be getting it close to a release.

darrell_ulm’s picture

Well, the Patch in #44 still applies fine (apologies for the absence, doing more C# stuff recently and of course the general Drupal maint.)

I would like to take a quick look at it for anything notable.

Thanks @umtj

darrell_ulm’s picture

Hi @umtj, and all. Looks really good, getting there, been testing this and it's very close.

The tagging seems to work, permissions, and admin - setting page for the module. The moderation page is close but still a few issues remain:
admin/content/abuse.

Thank you again @umtj, after testing, I added the

darrell_ulm’s picture

Status: Needs work » Fixed

Marking this as fixed as the majority of the Drupal 6.x to 7.x is done, there are just some bug fixes needed and these can be branched out in separate tickets to keep things organized.

darrell_ulm’s picture

Title: 6.x to 7.x version » 6.x to 7.x version upgrade - main issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.