Closed (fixed)
Project:
Abuse
Version:
6.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
16 Mar 2012 at 00:25 UTC
Updated:
13 Aug 2015 at 16:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
markwk commentedGlad to see this has started. I've been checking this project off and on for a D7 port. Post when you are ready for testing.
Comment #2
darrell_ulm commentedHi, I am getting close. There are some database calls to convert to the D7 api methods and then it ought to be working.
Comment #3
darrell_ulm commentedBack to looking at this one again.
Comment #12
darrell_ulm commentedMore progress, although not enough to make a 7.x-1.x release quite yet. Thinking it will be easier to incorporate some of the enhancements people are looking for in the 6.x version in Drupal 7.
Want to have a dev release soon for testing.
Comment #18
umtj commentedI'v been working on this patch for a couple of days.
The patch includes:
- Loading of user account in _abuse_load. Include it in the object. This changes templates too.
- A lot of markup changes in templates.
- Changed it to use entities instead of nodes, comments and users.
- Forms changed to D7.
- Removed $flagger, $admin, $suerpadmin and $configure from hook_menu. Way better reading this way.
- Reviewed SQL queries.
- Rewrote much of _abuse_load function.
- Cleanup of comment function.
I think that's about it. Let me know if i'm on the right track!
Comment #19
darrell_ulm commentedHey thanks,
Assuming this is meant to apply against the dev branch, and I want to do a review of the code before adding it of course.
Thanks again.
Comment #21
darrell_ulm commentedIn general it's improved, many improvements.
These paths do not work now, but there were issues with them prior and in general looks like it's headed in the right direction.
Paths:
admin/abuse/status/node/node#
abuse/report/node/node#
So, getting there, but still more to do. Thanks again for the patch, and gave you the author credit obviously.
Comment #22
darrell_ulm commentedActually it works better that I thought. Added entity module dependancy, and things work better now. :)
Comment #25
umtj commentedquantumtime committed d7d0166 on 7.x-1.x-dev, why the $user = $GLOBAL['user']?
quantumtime committed db32885 on 7.x-1.x-dev, in template why not use render?
Comment #26
umtj commentedA colleague of mine made a lot of changes to templates.
Here's a patch for the templates.
He's username is: martinyde.
Comment #27
darrell_ulm commented@umtj, thank you. Can he/she submit the patch her/him self? If added, who shall I give credit.
Also, the whole thing needs a complete code review before we make any type of release.
Comment #28
umtj commentedHe cannot at the moment. That's why I posted it. But the correct username should be 'martinyde'.
I agree! A codereview is very much needed.
Comment #29
darrell_ulm commented@umtj, Intend to incorporate this soon, and thanks!
Comment #30
umtj commentedSmall patch removing hook_user_access(). Not sure what it's for.
Comment #31
darrell_ulm commentedHi @umtj, agreed we need to evaluate some of the D6 to D7 changes and see what is still needed or not, as well as really test security with a fine toothed comb.
Right now I'm a bit busy with some work I absolutely need to get done this week, but we can take a look at these patches soon.
Thank you for again your input @umtj!
Comment #32
umtj commentedUpdated user_access patch!
Comment #33
umtj commentedForget about user_access2.patch, use user_access3.patch please.
Comment #34
umtj commentedSorry about this. This patch should be final for user_access.
Comment #35
umtj commented_abuse_get_assigned_count function updated with correct usage of db_or. groupBy and range is not supported in db_update funciton.
This is really messy. I'll need some help here!
Comment #36
umtj commentedSmall bugfixing, enjoy!
Comment #37
umtj commentedSorry, last patch had an issue.
Comment #38
darrell_ulm commentedThanks, @umtj.
Questions to save time:
Thank you!
Comment #39
umtj commentedHere's a patch for taxonomy in abuse_entity_view.
Will these patches apply in order? Yes
Is there any way to wrap them into 1 patch? I could but why another file?
Comment #40
umtj commentedHere's a fully patch.
Comment #41
umtj commentedComment table corrected.
Full patch.Comment #42
umtj commentedSo here a new patch. This one should be full and with a lot of changes in code, style and comments.
Comment #43
umtj commentedGuess i cleaned a bit too much up. Here's a version with working tabs and a little bug fixing in abuse.admin.inc.
Comment #44
umtj commentedallow/remove functions updated
Comment #45
darrell_ulm commented@umtj Large patch. I'll try to get some time to look at it over the long weekend.
Comment #46
umtj commented@quantumtime do you need any help?
Comment #47
darrell_ulm commentedHi @umtk, this module is an experimental upgrade for me, just for fun, and I've been onto some non-Drupal IT projects recently, my short break will not last.
You can ask @BTMash to make you a co-developer on this and you should be able to make your own commits, if you feel comfortable doing so.
Comment #48
darrell_ulm commented@umtj Pretty sure you'll need to ask @BTMash to give you permissions instead of me. Thanks again.
Comment #49
btmash commentedSorry, I was not subscribed to this issue and just saw it now. I made @umtj a maintainer so you can both work on the 7.x version.
Comment #50
darrell_ulm commentedThank you @BTMash, the large patch of @umtj could be getting it close to a release.
Comment #51
darrell_ulm commentedWell, the Patch in #44 still applies fine (apologies for the absence, doing more C# stuff recently and of course the general Drupal maint.)
I would like to take a quick look at it for anything notable.
Thanks @umtj
Comment #52
darrell_ulm commentedHi @umtj, and all. Looks really good, getting there, been testing this and it's very close.
The tagging seems to work, permissions, and admin - setting page for the module. The moderation page is close but still a few issues remain:
admin/content/abuse.
Thank you again @umtj, after testing, I added the
Comment #53
darrell_ulm commentedMarking this as fixed as the majority of the Drupal 6.x to 7.x is done, there are just some bug fixes needed and these can be branched out in separate tickets to keep things organized.
Comment #54
darrell_ulm commented