Closed (fixed)
Project:
Smiley
Version:
7.x-1.0-beta2
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2012 at 01:45 UTC
Updated:
4 Apr 2012 at 02:55 UTC
Jump to comment: Most recent file
Comments
Comment #1
fizk commentedDid you read the README.txt file?
Comment #2
Steel Rat commentedYes I did, and the install.txt file. Neither of them mention such a thing.
I also went through all the config options, and added the Smiley text filter to both filtered HTML and Full HTML, and moved it down in the filter list as suggested. Can someone provide a screenshot of how it should look to someone creating a forum topic or adding a comment?
Comment #3
fizk commentedIt works for me with and without advanced forum enabled. I'm not sure why it's not working for you. I've attached a screenshot of what a forum topic with a comment looks like, both with a smiley.
Comment #4
Steel Rat commentedNot sure we're talking about the same thing. I'm referring to the add comment or add forum topic form, where one would normally see the list of available smileys. Presumably they could then click the smiley they want to use and it would insert into the text area at the cursor.
Comment #5
fizk commentedOh, ok. You should use a WYSIWYG editor (TinyMCE, CKEditor, etc) and the WYSIWYG smiley module to add a "insert smiley" button to the toolbar of the editor.
Comment #6
Steel Rat commentedI use BUEditor. I'd rather not change to a different editor.
Comment #7
fizk commentedOk, you can wait for #429684: Add editor: BUEditor to be resolved so that BUEditor is integrated with the WYSIWYG module.
Comment #8
Steel Rat commentedIsn't there a better way than forcing one to use a specific editor, or to use a WYSIWYG at all? the previous smileys module for D6 didn't have this requirement, it simply had an expandable link where one could click a smiley and insert it at the cursor.
Comment #9
fizk commentedUsing a wysiwyg editor isn't a difficult or a bad way to go. You can completely customize which buttons should appear on the toolbar. For example, if you want only the smiley button to appear, you could do that.
Comment #10
michelleI haven't had a chance to use this, yet, in D7. Am I reading correctly that the module has WYSIWYG as a dependency? If so, that's a pretty big regression over Smileys. You are, of course, free to do your module however you please but that's a pretty big showstopper for a lot of people.
Comment #11
fizk commentedNo, this module isn't dependent on WYSIWYG.
There's a submodule that provides a "Insert smiley" button on a WYSIWYG toolbar. That submodule has a dependency on WYSIWYG.
Comment #12
Steel Rat commentedYou're missing my point, fizk. The D6 smiley module didn't require a WYSIWYG editor. This one does. That's not trivial for many folks. I had been using BUEditor for years, but this module isn't compatible with just plain Drupal 7. Hopefully you'll consider including basic functionality which doesn't require something more complex be installed.
Comment #13
fizk commentedSteel rat, this module does not require WYSIWYG.
The main purpose of replacing text smiley faces with graphical smiley faces is accomplished without any dependency on the WYSIWYG module or a WYSIWYG editor.
I think what you're looking for is the "Textual smiley will be replaced with graphical ones" text below the textarea that links to the "Compose tips" page. This can be added to the D7 module.
Comment #14
fizk commentedA link pointing to the format tips page has been committed.
Comment #15
michelleAh, that's good to know. Thanks. :)
Comment #16
Steel Rat commentedWell, no what I was talking about was then when the module is enabled, there is no indication to the user that smilies are available. That's what I mean by user presentation. They have to guess what's there. Your comments #5 and 7 clearly indicate that one needs to use a WYSIWYG editor to gain the functionality that should already be there.
Comment #17
fizk commentedThere are two users, the website administrator and the end-user (either anonymous or a logged-in user).
The way it works right now:
The website admin doesn't need a special message telling him that smileys are available. He knows by looking at the modules page and by reading the README/INSTALL.txt file that tells him to go to "Configuration > Content authoring > Text formats" and enable the Smiley filtering for your preferred Input formats.
After the last commit, the end-user will know that smileys are available because a "Textual smiley will be replaced with graphical ones" message appears below the textarea that links to the "Compose tips" page. The "Compose tips" page lists all the smileys that are available on the website, and how to produce them.
My guess about what you're looking for:
When the website admin enables the module, a message should appear saying "Please click here to enable Smileys for your preferred Input formats."
Comment #18
fizk commentedSteel rat, try to be more specific about your feature request.
Try phrasing it like, "I want to see the message "xxxxxxxxx" displayed on page yyyyyy when the web admin/end-user does zzzzzzzzzz."
Comment #19
michelleI think the issue here is that the original Smileys module has a box with the graphical smilies there for users to click on that does not require WYSIWYG. From what I'm reading, this module will do the filter replacing without WYSIWYG but does not have a visible list of smilies on the post itself for users to click without it.
Comment #20
fizk commentedOh, I see now. I've created a new issue: #1513658: Restore smiley select box feature from D6
Comment #21
michelleThat sounds perfect. Thanks!
Comment #22
Steel Rat commentedSorry, fizk, I thought I was clear since I was referring to node/comment creation and not administrative tasks. Michelle has it exactly right. The Compose Tips page is too cumbersom a way to show something quickly and easily.
Thanks for your time, patience, and hard work!