The attached patch is for commerce kickstart 1.2 as well as the following modules:

commerce_eway 7.x-1.x-dev (2011-Jul-28)
commerce_recurring 7.x-1.x-dev (2012-Jan-24)
commerce_cardonfile 7.x-1.x-dev (2011-Nov-08)

Commerce_recurring uses commerce_cardonfile to handle recurring orders.

This patch adds code to the commerce_eway module so that it can complete recurring payments if eway is set to use Token Payments.

Notes:
- Set cardonfile to use only 1 credit card per customer (not tested with multiple!)
- Set cardonfile to hide the "store card info" checkbox

CommentFileSizeAuthor
#9 commerce_eway-cardonfile-recurring-1484520_4.patch23.07 KBthtas
#8 commerce_eway-cardonfile-recurring-1484520_3.patch8.53 KBthtas
#6 patch_commit_135ea6917ee6.patch8.52 KBthtas
#4 commerce_eway-cardonfile-recurring-1484520_2.patch10.19 KBthtas
#1 commerce_eway-cardonfile-recurring-1484520.patch10.15 KBthtas

Comments

thtas’s picture

thtas commented
StatusFileSize
new commerce_eway-cardonfile-recurring-1484520.patch10.15 KB

patch attached

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

thanks! will look at this during drupalcon denver.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

before i get into functionality and testing, please review this: http://drupal.org/coding-standards

there are lots of places in the patch that don't meet the coding standards.

thtas’s picture

thtas commented
StatusFileSize
new commerce_eway-cardonfile-recurring-1484520_2.patch10.19 KB

Oh i didn't really think of that! I ran it through the coder module to try and clean things up a bit. Thanks for letting me know.

berenddeboer’s picture

berenddeboer commented
Status: Needs work » Closed (fixed)

Committed.

thtas’s picture

thtas commented
StatusFileSize
new patch_commit_135ea6917ee6.patch8.52 KB

Here is an additional patch with fixed for this (to be applied to current 7.x dev)

- Fixed a typo, updated some debug messages
- Added support for the owner field as mentioned in #1505396: Card owner field on payment form
- Fixed the logic around adding new card data

thtas’s picture

thtas commented
Status: Closed (fixed) » Needs review

updating issue status

thtas’s picture

thtas commented
StatusFileSize
new commerce_eway-cardonfile-recurring-1484520_3.patch8.53 KB

A new patch with all the changes mentioned in my other tickets and some more bug fixes

this includes the patches from:

#1797326: Stop storing credit card information within the session object when saving token users
#1797038: [META] Fixes for rules inc
#1797014: Basing eway charge off order number instead of order id
#1797010: Check for address parts before concatenation
#1797000: support for a logged in user making a purchase
#1796988: Add a bit more feedback about failed payments on checkout submission
#1505396: Card owner field on payment form

This is against the dev branch as of Oct 3 2012. (specifically branch 71e0ec54c3b4d42d15962bb9ce89c5912212f882)

thtas’s picture

thtas commented
StatusFileSize
new commerce_eway-cardonfile-recurring-1484520_4.patch23.07 KB

updated patch also includes changes from #1845106: Remove dependency on address fields

rcross’s picture

rcross commented

thtas - please keep separate patches. I won't commit a meta patch like this.

rcross’s picture

rcross commented
Status: Needs review » Closed (fixed)

The original patch here was already committed. Please open a new issue for anything in your updated patches that isn't already open.

rcross’s picture

rcross commented
Issue summary: View changes

updated desc