I followed the instructions in the README (also set CCK text fields to "Filtered text (user selects input format)", as mentioned in another issue). The conversion appeared to work, there were no apparent errors and the content of the importable fields of all 43 of my flexinode-1 records were imported into my content_type_job table. However the type field of the node table was not updated: all 43 remained as flexinode-1.

I've worked out what happened: I got the message "Boo!!" during conversion. Looking at flexiconvert.module, this means $count_converted != $count_to_convert and the type update is bypassed. This occurred because $count_converted is set as the count of SELECT nid FROM {$cck_table} and I already had 1 record of the relevant CCK type.

The attached patch fixes this by counting the CCK nodes before and after conversion.

CommentFileSizeAuthor
flexiconvert-count.patch1.32 KBdavej

Comments

davej’s picture

davej commented
Title: node type not updated » node type not updated when there are existing CCK nodes
Status: Active » Needs review
anarcat’s picture

anarcat commented
Status: Needs review » Patch (to be ported)

Patch doesn't apply cleanly on head but seems conceptually sound.

anarcat’s picture

anarcat commented
Version: 5.x-0.2 » 4.7.x-1.x-dev

Actually, this looks like this patch is designed more for 4.7.x.

anarcat’s picture

anarcat commented

Scratch that: the patch *was* designed for 5.x-0.2, but that branch has been rewritten and doesn't have the bug anymore so this patch only needs to be backported to 4.7.x.