Ad blocks which were previously assigned/configured from the blocks configuration lose their configuration/placement in this upgrade. For example, 'ad group: x', which was previously placed in the header with weight -9, checked 'on', and limited to '/path' has lost these settings.

Comments

jeremy’s picture

jeremy commented
Status: Active » Fixed

Please download the latest development snapshot, this bug was already fixed.

casconed’s picture

casconed commented

No, this is a different issue. Ad groups which were set to display as blocks lose their settings in the blocks configuration. The change appears related to a change in the 'delta' field for those groups in the 'blocks' table. The update process for Ad leaves this data intact but as soon as the 'admin/block' is accessed all settings are lost for these groups.

casconed’s picture

casconed commented
Status: Fixed » Active

reopening as active

jeremy’s picture

jeremy commented

I don't know a good solution for this. Perhaps I should just add a note to the upgrading instructions -- is it too difficult to manually reconfigure your blocks after you upgrade?

casconed’s picture

casconed commented

I suspect that this is just a necessary evil of migrating to a better/more efficient system for the ad groups, but was hoping there was something that could be tripped as part of the update, as I have about 30+ ad groups placed in different parts of my site that need updating. I will probably just end up dumping the blocks table from phpmyadmin pre-update, installing, and reimporting with (updated) deltas.

jeremy’s picture

jeremy commented

Can you compare the deltas before and after the upgrade? Are they perhaps off-by-one? In particular, is it the default group that moved, adjusting all other blocks in the process? If so, that would be easily fixable. If you can help me track down what is causing this delta shift (probably by answering my questions above), it should be fixable. I'd like to see the upgrade process be as painless as possible.

casconed’s picture

casconed commented

pre-upgrade deltas are 1 - 31, and post upgrade they jump to 66 - 96. They all increment by the same amount - 62, except the default group which changes from 1 to 0.

jeremy’s picture

jeremy commented
Assigned: Unassigned » jeremy
Status: Active » Fixed

Okay, I have checked in a fix for the 4.7.x and 5.x development trees. This can't fix sites that were already upgraded, but should work fine for 1.0 sites being upgraded to 1.1.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)