Expected:
features_tools_disable_features_page_js
Actual:
featrues_tools_disable_features_page_js

Love this module, thanks!

CommentFileSizeAuthor
#1 variable-misnamed-1486476-1.patch2.45 KBcrazyrohila

Comments

crazyrohila’s picture

crazyrohila commented
Status: Active » Needs review
StatusFileSize
new variable-misnamed-1486476-1.patch2.45 KB

Thanks for pointing that out . here is a patch.

perelman.yuval’s picture

perelman.yuval commented
Status: Needs review » Patch (to be ported)

hi all.
thanks for the feedback and for the patch.
i will port it to the dev version as soon as posible.

perelman.yuval’s picture

perelman.yuval commented
Status: Patch (to be ported) » Closed (fixed)

hi all i add it to the dev version.
will be in the next stable relase (after we add cck unlink support and staff like that...).
thanks again.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

While renaming a settings variable you also should have added an update hook, which first copies the old variable to the new one and later unset the variable. Otherwise you will leave an unused variable and the user has to reconfigure the settings (without knowing that he has to).

perelman.yuval’s picture

perelman.yuval commented

you are right
thanks.