if i open "themesettingsapi.pot" POEdit is telling me this file is "iso-8859-1". i regenerated the files again with drupal-pot extractor and got the same result. There looks like a big encoding bug inside your modules. I think your files are not clean UTF-8...

Additional trying to open the file "themesettings.pot" in POEdit results in a "Failed to convert file contents to Unicode". I'd recreated this POT file myself and this error is gone, but the above "iso-8859-1" bug is inside, too.

PoEdit 1.3.6 was used on Windows and i never ever have had any problems with other modules...

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Assigned: Unassigned » johnalbin
Status: Active » Fixed

I’ve checked the themesettings.pot file and, indeed, it is ISO Latin 1 encoded. But the modules are definitely proper UTF-8 files.

I re-generated these with drupal-pot’s extractor.php script, and this time they are UTF-8. I don’t know what happened last time. Sorry about that!

Updated .pot files are in 5.x-1.x-dev and in HEAD. Hass, if you are doing a translation, I will wait for it before releasing 5.x-1.4. Translate away!

hass’s picture

hass commented

well,.. i'm working on German translation. hope to be finished today.

hass’s picture

hass commented
Status: Fixed » Active

Downloaded latest POT files and opened with POEdit.

1. Go to catalog
2. options
3. encoding - "iso-8859-1"

hass’s picture

hass commented

building pot from files results in a general.pot in "iso-8859-1" and a themesettings-module.pot in "utf-8"

PHP Warning:  join(): Bad arguments. in D:\InetPub\wwwroot\drupal-contrib-5\modules\themesettings\extractor.php on line 213
johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Postponed (maintainer needs more info)

Hass, it takes up to 12 hours before Drupal re-rolls -dev releases into tar balls. i suspect you downloaded the old -dev release. I have verified that the latest -dev is now available and has the UTF-8 encoded .pot files.

Can you try again?

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Active

Well, this is why i took the file out of CVS directly...

hass’s picture

hass commented

rechecked the dev build and it's "iso-8859-1" again.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Project: Theme Settings » Theme Settings API
Version: 5.x-1.3 » 5.x-1.4
Status: Active » Fixed

Ascii, iso-8859-1 and utf-8 encodings are indistinguishable if the text file only has ASCII characters in it.

The .pot files are utf-8. But, as I said, an utf-8 encoding of this particular file is equivalent to an iso-8859-1 encoding. So make sure your editor opens the .pot files as utf-8. Otherwise, when you add higher-byte level characters (like umlauts or curly quotes), your editor will encode those characters as iso-8859-1 instead of utf-8.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)