The Spambot Guard module enables you to add a simple addition question to common forms to help block automated spammers from polluting your site. It is much easier on users and in most cases is just as effective as a ridiculous image CAPTCHA.

Spambot Guard

Comments

donpwinston’s picture

Repository view is screwed up for some reason but GIT says everything is up to date.

patrickd’s picture

Status: Needs review » Needs work

Not screwed up, it's empty. ;)

Please have a look at the instructions how to use git on drupal.org.

donpwinston’s picture

Looks like it entangled with my other project XML Transform. Shouldn't they be in two different trees?

donpwinston’s picture

Status: Needs work » Needs review

Bought Gitbox from the App store. It looks like it did the right thing. Should be ok now.

patrickd’s picture

Yep now it's there, but branch name is not following the release patterns.

I'm afraid that this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project. (adding tag)
Consider trying it again with another *little* more complex module, or - if possible - try to add more functionality to this module, so there's more to review.

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Please take a moment to make your project page follow tips for a great project page.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxdonpwinston1487468git...

You can also get a review bonus and we will come back to your application sooner.

chertzog’s picture

Review:
First you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
(At least this has to be done before switching back to needs review)

After you get your branches taken care of, run your module through the Ventral PAReview and Coder.

On line 71 of your module file:

 '#title' => t("What is 2 + $rnum?"),

You should not directly translate variables. You should use a placeholder.

 '#title' => t('What is 2 + !rnum?', array('!rnum' => $rnum),

Then in .admin.inc you use this function:

function spambot_guard_admin_settings() {
...
'#options' => array( //Should be able to fetch a list instead of typing these in manually
                           'comment_node_article_form' => t('Article Comment'),
                           'comment_node_forum_form' => t('Forum Comment'),
                           'comment_node_page_form' => t('Page Comment'),
                           'user_register_form' => t('User Register'),
                   ),

to generate a form to list the forms you want to protect. What if i create my own content types? They cant be included if you hard code these options. Look into using node_types_get_types()" to generate a list of all the content types in the system.

Along the same lines, what about other forms? Custom forms from other modules, Webforms, node add forms for content types that users can create?

The CAPTCHA module does provide a math option, so i dont think this module provides enough differentiation to warrant a new module. If I am wrong on this, please explain the differences.

chertzog’s picture

@patrickd Sorry, didnt mean to remove the tag. I was working on the review when you posted your comment.

donpwinston’s picture

Status: Needs review » Needs work

I'll make the admin smarter.

donpwinston’s picture

If the existing modules do this then I won't bother with this. I was just using this as an educational exercise to learn GIT and Drupal anyway.

donpwinston’s picture

Status: Needs work » Closed (duplicate)

There's a similar technique in the CAPTCHA Pack module. Also, there are other techniques like hidden questions, identify a missing letter, and identifying a word that does't belong in a list that are also better then the image CAPTCHAs. I'm closing this. I'll think of something else to do.

donpwinston’s picture

Issue summary: View changes

typo

avpaderno’s picture

Issue summary: View changes
Status: Closed (duplicate) » Closed (won't fix)