i've enabled the module and and added the field for my view that shows an unformatted list of nodes using fields.

when i go to that view every view with the unformatted format on this page has a shadow at the bottom and the right side, not just the view with the inline comments field. i have an tagcloud in my second sidebar that shows floated left tags with weighted fontsize but now all tags are shown among each other and each tag has these shadows.

CommentFileSizeAuthor
#2 fix_css_less_generic-1487650-2.patch2.34 KBkitkat13

Comments

ghankstef’s picture

You have a good point this should be for this views not all views. The CSS is too generic. The offending CSS is here in the inline_comments_views.css file:

.views-row {
background: #eee;
margin: 2em 0;
padding: 2em 2em 4em;
box-shadow: 3px 3px 5px 0 #ccc;
border-radius: 5px;
}

For the moment you can override this in your own css files in your theme. I'll work on a way to add this just to inline comments views with more specific classes.

kitkat13’s picture

StatusFileSize
new2.34 KB

I made a little patch for this.
But I don't know what is exactly '.user-signature' ?!

simon georges’s picture

@kitkat13, .user-signature shows when you activate User signatures in Configuration / Account Settings. The signature is then displayed with the comments.
It may not appear in your case because signatures are disabled.

kitkat13’s picture

Status: Active » Needs review
grasmash’s picture

Also, this patch relies upon CSS3. Ideally, the css should be cross-browser and backward compatible.

simon georges’s picture

@madmatter23, I don't see how the patch relies more on CSS3 than the original code, am I wrong?

grasmash’s picture

You're absolutely right. I hadn't really dug into the module yet. My comment applied more to the original module than to your patch . I'm running through it and making a bunch of modifications.

simon georges’s picture

@madmatter23 Don't hesitate to post a sandbox if you have something better than the current module (and its mandatory patches...).

grasmash’s picture

I spent about half of a day making some substantial changes to this module, but I eventually decided to scrap the whole effort. This module does a bit too much 'reinventing the wheel' for me.

Instead, I patched the Ajax Comments. module:
#1711476: Views integration

I've added ajax integration for the Views 'add comment' field, which is the aspect of Inline Comments that I needed. I may go on to add 'View Comments' field, but I don't have plans to do it immediately.

grasmash’s picture

Issue summary: View changes

supplement