http://api.drupal.org/api/drupal/includes%21common.inc/function/format_p...

Examples:

Select the proper editorial group(s) for this content.
%title is assigned to the %section editorial group(s), which may not be changed.
%title is also assigned to the %section editorial group(s), which may not be changed.
CommentFileSizeAuthor
#22 1487720-workbench_access-translatable_strings-20.patch12.2 KBagentrickard
#20 workbench_access-translatable_strings-1487720-20.patch10.92 KBdrupalmonkey
#18 workbench_access-translatable_strings-1487720-18.patch5.73 KBdrupalmonkey
#9 1487720_workbench_access_Translatable_strings_review.patch8.48 KBhass

Comments

hass’s picture

hass commented

And please don't be "lazy" writing strings...

Bad example:
Editorial sections updated

Good example:
Editorial sections have been updated.

hass’s picture

hass commented
Version: 7.x-1.x-dev » 7.x-1.0

Cannot guess what this means in the context it is used. Sentence is tooo short.

Editor settings.
Configured
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.0 » 7.x-1.x-dev

Patch please since we're "lazy"

hass’s picture

hass commented
Version: 7.x-1.0 » 7.x-1.x-dev

Don't take it personally, please. It's only to say - Write long strings that are self explainatory, please. I'm sure I cannot as I have no idea what the strings mean and you know best your own logics.

hass’s picture

hass commented

Can someone explain with some other words what "Exhibits" means, please?

  $terms = array(
    $t('Exhibits'),
    $t('Library'),
    $t('Gift Shop'),
  );
hass’s picture

hass commented

Context sensitive issue:

t('Editorial assignments by @type', array('@type' => $type))

In German the type need to be uppercase first. This is not possible with this type of implementation. No idea what the possible types are. I also strongly suggest to use %type for placeholders to show the placeholders with <em>Editor</em>.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Title: Translatable strings review » Translatability issues, format_plural not used
Status: Needs review » Active

Exhibits == a display of items, as in a museum, or a collection of such displays.

I do not understand comment 6. I think the complaint is that the placeholder name is unclear. It is the "name of the section." So you want %section_name here?

And that value should already be uppercase, if needed, since it is actually a Term name or Menu Link title.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Re: #1. In English, those two verb tenses are nearly identical, and the longer form is not needed. It is, in fact, introducing useless words that make messages less clear.

Do we have general standards about such verb formations?

And, when calling out errors, please give references to file and line number if you're not going to patch.

hass’s picture

hass commented
Title: Translatability issues, format_plural not used » Translatable strings review
Status: Active » Needs review
StatusFileSize
new 1487720_workbench_access_Translatable_strings_review.patch8.48 KB

Patch attached.

hass’s picture

hass commented
Title: Translatability issues, format_plural not used » Translatable strings review
Status: Active » Needs review

@agentrickard:

I do not understand comment 6. I think the complaint is that the placeholder name is unclear. It is the "name of the section." So you want %section_name here?

%section_name would make the content clearer, but cannot solve the issue.

In German the translation in the UI is Zuordnung zu Redaktionsbereichen nach editor, but it need to be Zuordnung zu Redaktionsbereichen nach <em>Editor</em>. The "editor" string is a context sensitive translation issue as it's not in the translators hand to capitalize the word correctly. This bug is not fixed with patch in #9.

or Zuordnung zu Redaktionsbereichen nach role should be Zuordnung zu Redaktionsbereichen nach Rolle. Here I'm also not able to translate the word role

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Right, sorry, I misread my own code out of context. %type is appropriate. The possible values are "Editor" and "Role".

So we have to rewrite the heading to make it easier to translate? What kind of context would suffice here?

hass’s picture

hass commented

#1 is a core rule, that have been made the standard some years ago... but don't ask for refrence links please... :-)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I have no problem with these proposed changes except this one:

-    'description' => 'Editor settings.',
+    'description' => 'The editor assignment settings.',

If we're going to expand that, we should make it more explicit. But I also do not see any place in the UI where this text is used.

We should probably bring it in line with the phrase used for ['user/%user/sections'].

'Assign users to sections for the Workbench Access module.'
'Assign editors for the Workbench Access module.'
'Assign roles for the Workbench Access module.'
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

If #1 is a core rule, we need to document it. Sounds like it needs to go (at least as a placeholder page) in one of these places:

https://drupal.org/coding-standards
https://drupal.org/node/303984

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Or, perhaps https://drupal.org/node/322729 See the issue at #1487798: Document style preferences for translatable text

hass’s picture

hass commented

The easiest and savest solution you can implement is:

Editorial assignments by Editor and Editorial assignments by Role.

I know it's static, but this is the only way that really works. I found one more...

hass’s picture

hass commented

- 'description' => 'Editor settings.',
+ 'description' => 'The editor assignment settings.',

No problem, feel free to change it. I only tried to make it more explainatory, but was also not sure how it would be the best and used something from the page the link points to... :-)

drupalmonkey’s picture

drupalmonkey commented
StatusFileSize
new workbench_access-translatable_strings-1487720-18.patch5.73 KB

Re-rolled the patch against latest 7.x-1.x branch..

Added an if statement to help with the context issues with the placeholders.

hass’s picture

hass commented

There are a number of lines that are missing compared to my patch!?

drupalmonkey’s picture

drupalmonkey commented
StatusFileSize
new workbench_access-translatable_strings-1487720-20.patch10.92 KB

argh. That's my bad, hass. Re-rolled patch again.

hass’s picture

hass commented
Status: Needs review » Reviewed & tested by the community
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new 1487720-workbench_access-translatable_strings-20.patch12.2 KB

Committed with the following minor changes:

* Removed capitalization of Editor and Role on the settings overview pages. This change brings that text in line with the per-section settings pages.
* Removed unwanted period in h2 area.
* Standardized use of "account" instead of "user" in admin links.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Commit: 949faba..87a2d32

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.