Closed (fixed)
Project:
New Relic
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2012 at 17:43 UTC
Updated:
12 Jun 2013 at 14:00 UTC
Code Review complains about string concatenation whitespace formatting in a bunch of places. In the report overview table, it complains on every column:
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
$v['METRIC']['mval'] > $v['METRIC']['thresh'] ? ''.$v['METRIC']['val'].'' : $v['METRIC']['val'],
Rather than simply fix the spacing issue I rewrote this section of code to eliminate the redundancy and in-line html. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| new_relic_rpm-metrics-table-cleanup.patch | 2.3 KB | jonathan webb |
Comments
Comment #1
neclimdulthanks berdir