Don't show "more tags" when all tags are already shown
Dieter_be - June 2, 2007 - 17:38
| Project: | Tagadelic |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
When all available terms (tags) are already shown, there is no use for the "more tags" link in the bottom right corner
#1
I have patched the tagadelic.module by replacing
$blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more linkwith
if (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) {$blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more link
}
This works really nice.
#2
Features into HEAD, I guess? Patch for suggestion attached, not tested on my side.
#3
(Ignore me)
#4
First priority is a DPL6 release.
Then I will open up head for development on new features and bugfixes.
#5
Just reporting back that this patch applies with fuzz against 6x-1.0 and works as expected.
#6
I recall having duscussed this before, but fail to find that thread:
Why do you check
<?phpif (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) {
?>
<?phpif (count($tags) => variable_get('tagadelic_block_tags_'. $delta, 12)) {
?>
I would say that the *more* must show in case there are the same, or more tags in the cloud then shown in the block. Is that correct?
#7
I think he used == because $tags will never have more than 12 (or whatever the setting contains) elements (the query uses
db_query_rangeto limit the number of results).That works fine, but I think >= is more readable and unambiguous.
#8
Bumping.
#9
Leafish, can you summarise what work needs to be done still?
#10
Well, both the patch above and the one attached here work - this one uses ">=" for the reasons in #7. I'm currently using this patch on a single Drupal 6 blog site and its doing the trick.
#11
looks good.
#12
+1
#13
Committed to DRUPAL-6-1.
Is not in the DRUPAL-6--1-1 release, though, that was released yesterday.
Will be in the next bugfix release and off course in the -dev version.
Also merged into HEAD.
#14
Automatically closed -- issue fixed for two weeks with no activity.