Download & Extend
Tagadelic » Issues

Don't show "more tags" when all tags are already shown

Posted by Dieter_be on June 2, 2007 at 5:38pm
Project:Tagadelic
Version:6.x-1.x-dev
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When all available terms (tags) are already shown, there is no use for the "more tags" link in the bottom right corner

Login or register to post comments

Comments

#1

Posted by jurgenhaas on September 6, 2007 at 1:50pm

I have patched the tagadelic.module by replacing

$blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more link

with

if (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) {
   $blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more link
}

This works really nice.

#2

Posted by leafish_paul on February 11, 2008 at 11:36pm
Version:5.x-1.x-dev» master
Status:active» needs review

Features into HEAD, I guess? Patch for suggestion attached, not tested on my side.

AttachmentSize
tagadelic_readmore_fix.patch 1.06 KB

#3

Posted by leafish_paul on February 12, 2008 at 12:06am

(Ignore me)

#4

Posted by Bèr Kessels on February 19, 2008 at 9:10am

First priority is a DPL6 release.
Then I will open up head for development on new features and bugfixes.

#5

Posted by add1sun on March 16, 2008 at 4:21pm

Just reporting back that this patch applies with fuzz against 6x-1.0 and works as expected.

#6

Posted by Bèr Kessels on May 1, 2008 at 1:38pm
Status:needs review» postponed (maintainer needs more info)

I recall having duscussed this before, but fail to find that thread:
Why do you check

<?php
if (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) {
?>
and not
<?php
if (count($tags) => variable_get('tagadelic_block_tags_'. $delta, 12)) {
?>

I would say that the *more* must show in case there are the same, or more tags in the cloud then shown in the block. Is that correct?

#7

Posted by cpugeniusmv on May 1, 2008 at 5:10pm

I think he used == because $tags will never have more than 12 (or whatever the setting contains) elements (the query uses db_query_range to limit the number of results).

That works fine, but I think >= is more readable and unambiguous.

#8

Posted by leafish_paul on May 25, 2008 at 9:37pm
Version:master» 6.x-1.x-dev
Status:postponed (maintainer needs more info)» needs work

Bumping.

#9

Posted by Bèr Kessels on August 14, 2008 at 7:18pm

Leafish, can you summarise what work needs to be done still?

#10

Posted by leafish_paul on August 18, 2008 at 1:41pm
Status:needs work» needs review

Well, both the patch above and the one attached here work - this one uses ">=" for the reasons in #7. I'm currently using this patch on a single Drupal 6 blog site and its doing the trick.

AttachmentSize
tagadelic_148793-2.patch 1.07 KB

#11

Posted by Bèr Kessels on August 18, 2008 at 1:53pm
Status:needs review» reviewed & tested by the community

looks good.

#12

Posted by jstoller on October 11, 2008 at 3:13am

+1

#13

Posted by Bèr Kessels on November 13, 2008 at 11:45am
Status:reviewed & tested by the community» fixed

Committed to DRUPAL-6-1.
Is not in the DRUPAL-6--1-1 release, though, that was released yesterday.
Will be in the next bugfix release and off course in the -dev version.

Also merged into HEAD.

#14

Posted by System Message on November 27, 2008 at 11:53am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.