Don't show "more tags" when all tags are already shown

I have patched the tagadelic.module by replacing

$blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more link

with

if (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) {
   $blocks['content'] .= theme('tagadelic_more', $voc->vid);//add more link
}

This works really nice.

Features into HEAD, I guess? Patch for suggestion attached, not tested on my side.

(Ignore me)

First priority is a DPL6 release.
Then I will open up head for development on new features and bugfixes.

Just reporting back that this patch applies with fuzz against 6x-1.0 and works as expected.

I recall having duscussed this before, but fail to find that thread:
Why do you check if (count($tags) == variable_get('tagadelic_block_tags_'. $delta, 12)) { and not if (count($tags) => variable_get('tagadelic_block_tags_'. $delta, 12)) {

I would say that the *more* must show in case there are the same, or more tags in the cloud then shown in the block. Is that correct?

I think he used == because $tags will never have more than 12 (or whatever the setting contains) elements (the query uses db_query_range to limit the number of results).

That works fine, but I think >= is more readable and unambiguous.

Bumping.

Leafish, can you summarise what work needs to be done still?

Well, both the patch above and the one attached here work - this one uses ">=" for the reasons in #7. I'm currently using this patch on a single Drupal 6 blog site and its doing the trick.

looks good.

+1

Committed to DRUPAL-6-1.
Is not in the DRUPAL-6--1-1 release, though, that was released yesterday.
Will be in the next bugfix release and off course in the -dev version.

Also merged into HEAD.