Code Review complains about whitespace formatting in a bunch of places. In the quick links list, it complains twice on every list item. For example:

Arrays should be formatted with a space separating each element and assignment operator
$output .= '<li>'.l('Overview', $urls['overview'], array('attributes'=>array('target'=>'_blank'))).'</li>';
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
$output .= '<li>'.l('Overview', $urls['overview'], array('attributes'=>array('target'=>'_blank'))).'</li>';

Rather than simply fix the spacing issue I rewrote this section of code to eliminate the redundancy and reduce in-line html. Patch attached.

Comments

neclimdul’s picture

Status: Needs review » Fixed

thanks berdir for committing

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.