I noticed that on line 241 of image.module it says:

$links['image_size_original'] = array('title' => t('original'), 'href' => 'node/' . $node->nid, 'query' => 'size=_original');

I'm pretty sure this is supposed to be:

$links['image_size_original'] = array('title' => t('original'), 'href' => 'node/' . $node->nid, 'query' => 'size='.IMAGE_ORIGINAL);

Am I wrong here?

CommentFileSizeAuthor
#4 image.module_148807.patch756 bytesdrewish

Comments

drewish’s picture

drewish commented

yeah, that looks like a bug. would you mind rolling a patch?

Vallenwood’s picture

Vallenwood commented

I just created a larger enhancement and bugfix patch which includes this. You can find it under "Configurable Resize Original patch plus other enhancements" at http://drupal.org/node/149093. Is that good enough?

drewish’s picture

drewish commented

It's not really. It's much easier to review, commit and track changes if each issue gets a separate patch. I'm going to commit each fix independently with it's own message referencing an issue number. If you break it up I don't have to try to figure out which bugs are addressed by which part of your patch. The net result of that would be that your fixes get committed much quicker.

drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new image.module_148807.patch756 bytes
drewish’s picture

drewish commented
Status: Needs review » Fixed

committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)