Rename <No value> to -No value-, so that we can translate/import a this string.

CommentFileSizeAuthor
#1 views-rename-no-value-1488558.patch1.29 KBwebflo

Comments

webflo’s picture

Status: Active » Needs review
StatusFileSize
new1.29 KB

Core uses spaces in those strings. see theme_options_none()

webflo’s picture

Title: Rename <No value> to -No value- » Rename <No value> to - No value -
tobiasb’s picture

Status: Needs review » Reviewed & tested by the community

thx ;-)

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Even i think any kind of string change is bad this place shouldn't be used that often, committed to 7.x-3.x

hass’s picture

There is something very bad in code...

<select id="edit-views-exposed-filter-any-label" name="views_exposed_filter_any_label" class="form-select">
  <option value="old_any"><Any></option>
  <option value="new_any" selected="selected">- Any -</option>
</select>

OLD_ANY need to be killed from code.

dawehner’s picture

That's just an admin settings page and well if the internal value is stored as "old_any" and "new_any", sure you can update them but just for a not easy to understand array key?

PS: That's somehow out of scope of that issue, you know that.

hass’s picture

The problem is wth core trying to detect this as html tag on transation import. As it's not a tag it will fail. This case is related as it discusses a generic issue that is 100% the same.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

added the code wrapper