[Shadowbox Login] Improved shadowbox login

The shadowbox login modal is showing login block in a modal so it must have both a registration and a lost password links. If those are not showed for you maybe is your theme that has hooked that block. Or maybe you have disable registration for visitors.

Anyway I'm thinking into changing that modal to show the three forms inside the modal.

Try this patch please. Take in mind too that it is not only the shadowbox login block links the ones that trigger the login modal. You can add menu links to trigger those login modals. A menu entry which path is "user/login" will trigger the login modal. A menu entry which path is "user/register" will trigger the register form modal. A menu entry which path is "user/password" will trigger the new password request modal.

Indeed any link which href is "user/login", "user/register" or "user/password" will trigger the modal.

Better patch.

The binary file, gif image, "bg.gif" has to be placed in the folder "/sites/all/modules/shadowbox/login_shadowbox/css/"

(1) Would be good to be able to set height and width for all 3 options, not just the login.
Heights where already configurable, width was the same for all 3 forms. Added individual width configuration for each form.

(2) Request new password doesnt open up in modal, take you directly to the node.
I introduced a bug in previous patch. Solved with this new one.

(3) When user logs in, keep the block visible but include now a link for "Logoff".
Added a configuration option on the shadowbox login block.

About the scroll should not appear when the configured widths, heights are enough to contain the forms. When the window is scaled the dimension can be not enough but it is the user who should scale up the window to see the form. Well, really those forms are not too wide, nor too high to be greater than a normal viewport in any modern monitor.

Reviewed CSS to try to solve the scrolling problem.

I have to read how to create the patches when there are new files, probably not the command I used or maybe the diff is not than against that 7.x-4-0.beta4.

Anyway still needs a little more tweak. I will include a new patch as soon as I have it finished.

I change the issue version because patches are always against development version. Probably when this issue started both development and 7.x-4.0-beta4 where at same stage.

New Patch that I think works with recaptcha. Now it even shows the errors in the modal so the modal only closes when the forms are succesfully submitted.

The previous patch is incorrect. I attach a new one, already tested.

It is to be applyed to the development 7.x-4.x-dev version and includes the binary file so is the only thing that needs to be applyed.

git clone --branch 7.x-4.x http://git.drupal.org/project/shadowbox.git

cd shadowbox

//  Then  you  download  the  patch  and  place  it  in  this  shadowbox  folder  and  apply  it
git apply  -v shadowbox_login-additional_links-1488718-18.patch

(1)
I suppose you mean that the shadowbox login does not look as good with Marinelli but I don't see shadowbox login breaking anything in Marinelli.

I can't do anything about the CSS not fiting every drupal theme but that's why the shadowbox login module has a configuration option to provide your own CSS. So anyone can customize it, even starting from the provided one if needed.

Besides the shadowbox login CSS file is loaded before any CSS of the theme layer so one can instead of providing own CSS in shadowbox login configuration, just overwrite any CSS rules to his needs in theme layer. In case of Marinelli that would be modifying the theme to add CSS rules for shadowbox login.

(2)
You must have enable the recaptcha option to "Use Ajax API". Without that option the recaptcha works correctly. This must be because I'm not adding all javascript on the pages loaded inside shadowbox login modal so I would need to review that in order to make recaptcha work with ajax api.

• Solved javascript error on admin pages.
• Tweaked CSS to try to make a theme independent Shadowbox Login Skin.
• Recaptcha using AJAX API should work now.

I have drupalized the shadowbox login block content. This is the modified patch.

The problem to make this patch is that there is a new binary file (not text file), the gif graphic file. So to create the diff we need to instruct git about that:
git diff --binary

Please, first clear any cache to be sure you are running new javascript files.

Check in console if there is any javascript error.

If you continue experimenting that problem then try another browser and report back with your result. Fails on all browsers or only a specific browser? I have tested several browsers and works fine for me that's why I wonder if this is a specific browser issue (ie maybe).

The buttons.png is a CSS mistake. There is a reference to an image file that is not available. I'm using CSS for buttons that I already had. No problem with that error. I already has it corrected some time ago in my local git folder.

And about the loading of the page in the modal is how it is intended to work. I can't think of doing it in a different way. The shadowbox modal is an iframe that loads the page with the form. When the user logins, it is detected -I tried to do it as soon as possible- and the modal is closed redirecting the parent page to the proper path. I don't know exactly why you see that more clearly in chrome than in other browsers but is working the same on all of them.

It would be better if I could do it in a different way but I can't think of other way. Anyway being an iframe gives the opportunity to get all the errors captured inside the modal and that looks great in my opinion.

But that lag you are seeing is just by design.

No, I would have to make another patch to include that. It is on a branch where I developed this feature. When this issue is finish I have to merge that branch with 7.x-4.x branch and push it. After that you can use the development version 7.x-4.x-dev without the need to apply patches.

Maybe is better if I do it already. Do you think it works as expected now?