TinyMCE ships with tables being used to render the buttons which helps to make clean rows and allows for the hiding/showing row functionality that Panopoly wants. However, WYSIWYG module overwrites the markup and this patch will roll that back. However, this can cause issues in IE and will break certain layouts. Ideally, the WYSIWYG code can be rewritten to include classes that can be used to do row toggling/presentation without relying on table styles.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | wysiwyg-table-format-1489096-10.patch | 1.29 KB | cboyden |
| #7 | wysiwyg-table-format-1489096-7.patch | 1.28 KB | sylus |
| #6 | wysiwyg-table-format-1489096-6.patch | 1.28 KB | saltednut |
| wysiwyg-table-format.patch | 1.15 KB | populist |
Comments
Comment #1
populist commentedThe solution here is likely to be complicated, but something like this should solve:
1.) Modify the WYSIWYG module to provide a row class that can go on the wrapper of each button. This would mean if a button is in row 3 it would have a class like wysiwyg-row-three.
2.) Modify the PDW plugin in Panopoly WYSIWYG to make the "toggle" functionality condition on those classes, instead of the TR tag it currently uses.
Comment #2
populist commentedComment #3
populist commentedComment #4
populist commentedI pushed up some basic CSS improvements to make TinyMCE look OK in IE9. This issue would be nice to address since it can help us run a mainline WYSIWYG module, but its not as bad as it once was.
Comment #5
populist commentedLets postpone this till later
Comment #6
saltednutRerolled this to work with 7.x-2.x latest - I know its a band aid but some may want to use the latest WYSIWYG dev?
Comment #7
sylus commentedAttaching patch for latest dev of WYSIWYG.
Comment #10
cboyden commentedRerolled to apply to latest 7.x-2.x. This will need some testing to see if it still does what it's supposed to and is still needed.
Comment #11
cboyden commented