Making the CSS and icons included with ELF optional would make the module a bit more versatile. While it's easy to override the CSS from within a custom theme it could be interesting to have the CSS disabled from the start. This is especially true in a multisite environment with multiple themes.
Patch adding this functionality will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | make-icons-optional-1489876-1.patch | 832 bytes | klaasvw |
Comments
Comment #1
klaasvw commentedThis tiny patch adds a configuration option to the global ELF admin form for excluding the css file. It defaults to including the css so it stays backwards compatible.
Comment #2
WorldFallz commentedSince the entire point of this module is to add the icons, can you explain this proposed feature a bit more? What's the point of using the module if you don't want the icons?
Comment #3
WorldFallz commentedThought about this some more-- you can also turn 'off' the icons with css. So I'm not inclined to add this.
Comment #4
klaasvw commentedThere may be some cases where simply a class is wanted, e.g. for giving the links a different color or using a custom icon provided by a theme.
Comment #5
WorldFallz commentedwhich can all be done via css... what am i missing?
Comment #6
klaasvw commentedIt saves you from overriding some css (in this case the background image). I know it's just a small thing so feel free to ignore if you don't want to introduce another variable.
Comment #7
WorldFallz commentedit's also relatively minor to add a variable, but given that it's easily overridden as is, I think opting not to add additional php and a variable is probably the 'right' answer. thanks for the patch/suggestion though!