Strict warning: Only variables should be passed by reference in basic_cart_checkout() (line 90 of /sites/all/modules/basic_cart/basic_cart.cart.inc).

Got this when doing chechkout.
It is easy resolved by replacing 90th line with code below:

  $tempform=drupal_get_form('basic_cart_checkout_form');
  $form = drupal_render($tempform);

Thank You for this great module! Very well done!

Comments

alex dicianu’s picture

alex dicianu commented

Hi,
Thanks for notifying me about this issue.
I think there is version problem .. I'll look into it.
In the mean time you can use the dev release.

alex dicianu’s picture

alex dicianu commented

I have updated the version on the project page. I had some problems with my computer and for some reason the wrong version was tagged. Sorry about that ... :(

ctrnz’s picture

ctrnz commented
Version: 7.x-1.x-dev » 7.x-1.1

Now you have it at line 210 in basic_cart.cart.inc
:)

alex dicianu’s picture

alex dicianu commented

Can you please tell me which version of drupal/php you are running?
Neither I, nor the drupal reviewers group, had this warning and I am wondering if there are more ...

ctrnz’s picture

ctrnz commented

I'm using those:
Drupal 7.12
PHP 5.3.8-pl0

alex dicianu’s picture

alex dicianu commented
Status: Active » Fixed

Fixed in the 2.0-alpha release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.