I can't get Forms interaction options in the edit flag form, so the Flag dialog module doesn't work. I think is a name convention issue. I noticed The flag dialog module file is called flagging_dialog.module, but the hooks are flag_dialog.

CommentFileSizeAuthor
#2 flag_should_be_flagging-1490422-2.patch10.47 KBmisc

Comments

misc’s picture

misc commented

I will look into this.

misc’s picture

misc commented
Status: Active » Needs review
StatusFileSize
new flag_should_be_flagging-1490422-2.patch10.47 KB

Attached the patch.
Soorry that I missed to rename the functions in the flagging dialog module....

rupertj’s picture

rupertj commented

Looks good to me, although one more that needs changing is the current implementation of hook_flag_form_interactions() in flagging_form.module. This should be flagging_form_interactions().

juandelacruzm’s picture

juandelacruzm commented

Thanks for all your hard work on this!

Scryver’s picture

Scryver commented

Thanks for this great expansion to flags!
-- @MiSc: Will create a new issue instead

misc’s picture

misc commented

@Scryver - could start a separate issue on this, and describe how to reproduce?

goron’s picture

goron commented
Status: Needs review » Reviewed & tested by the community

With this patch flagging_dialog worked for me. It looks like there are a few positive responses on here, so marking RTBC.

@rupertj - since this is about flagging_dialog module, I'm opening a new issue for the naming change you mentioned

goron’s picture

goron commented

here it is #1651342: Misnamed function in flagging_form module

misc’s picture

misc commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks, committed to latest dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.