Unless there's a good reason for them which I could perfectly miss, the drupal_goto's handling form redirection in webform_client_form_submit should probably be removed in favor of the recommended $redirect return value.

As is, they break the submission process and forbid any subsequent submit handler.

CommentFileSizeAuthor
#1 webform.module_5.patch1.02 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new webform.module_5.patch1.02 KB

While I'm at it, here's a patch

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Applied. Thanks yched, this fixes a ton of problems!

yched’s picture

yched commented

yep, saw that ;-)

simmerz’s picture

simmerz commented

Yes, that seems to solve the problems I was seeing too! Many thanks for the patch!

simmerz’s picture

simmerz commented
Status: Fixed » Active

Clearly I spoke too soon. It worked a couple of times that I amended the webform, and it has now lost the content from the cck fields again - I can't seem to get them back at all, despite entering the information again.

simmerz’s picture

simmerz commented

I updated to -dev and this branch works ok. so there must be additional changes not present in the patch above.

yched’s picture

yched commented
Status: Active » Fixed

fixed, then ;-)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)