File resource should not count itself to file usage

This pretty much makes sense to remove as file_field_insert and file_field_update are going to add a reference I'll try and roll a patch later today or tomorrow.

Like this?

Looks good to me.

Maybe this is needed after all. :(

When I try to create a node now with a file attachment that was just uploaded I get:
406 "The file used in the Image attachments field may not be referenced."

This is a form_error from file.module:556 file_managed_file_validate() method.

What is the correct way to upload a file and create a node with this file attached? If the behavior is changed with this patch, maybe this has to be documented somewhere.

#1484992: Attach file to node targeted_action

Ive reverted this commit Uploading files works but it needs some love. Let use this ticket as a task to make sure its working.

Its hard to call this a bug, but it basically is and I want to resolve it asap. Basically file saving in 7.x is a bit wonky and we need to make sure its perfect before 3.2 release.

whoops

The "may not be referenced" error only occurs when the file is permanent. Normally, the following happens: using the node form a file is uploaded via AJAX. It is stored in the file_managed table as temporary and not yet registered in file_usage. The fid is embedded in the form and when the entire node add/edit form is submitted, the file is made permanent and linked to the node. If the file is not linked for some reason, it will be cleaned up after six hours.

This issue is related to #1563130: Resource file:create_raw should set file status to permanent. Perhaps there should be two methods. One that creates a temporary file and does not register it in file_usage, which can be used prior to creating or editing a node. Another method would create a permanent file and register it in file_usage. This method can be used to upload a file without using it for a node or other entity.

Thanks for the hints Jorrit. Maybe something like this patch makes sense then?

I think it should work. Personally, I also need these changes for create_raw.

Can you re-roll this patch it doesnt apply to latest dev.

Re-rolled

As mentioned in #9

// Load the file via file.fid.
$file = file_load($form_state['values']['my_file_field']);
// Change status to permanent.
$file->status = FILE_STATUS_PERMANENT;
// Save.
file_save($file);
// Record that the module (in this example, user module) is using the file.
file_usage_add($file, 'user', 'user', $account->uid);

(Without the call to file_usage_add, file_managed_file_validate produces an error upon saving the form, saying that the uploaded file may not be referenced.)

The question becomes, Who's file is it anyway?

My {file_usage} table only has files with module: file , and type: node.

I don't have file fields attached to any other node types, but I imagine these comments on d.o would be another 'type'.

{file_usage} descriptions of the fields
module: The name of the module that is using the file.
type: The name of the object type in which the file is used.
id: The primary key of the object using the file.

Can id be changed later w/ file resource -> update?

Maybe if the module was set to file, and the type set to services... it could still be deleted. ?

File id's cannot be changed. they must be re-uploaded to get a new id.

Patch in #13 was wrong. New version attached.

Here is patch from #17 with added test to show how to upload file and "attach" it to the node.

@ygerasimov. Works as expected and tests passes here to. Thanks for bringing this home.

Go ahead on this one. Great work gentlemen(maybe some ladies?)

Committed. Thank you! e5d71e9