When there is also a "Latest version" the eye does not immediately distinguish that it is not recommended. In this case it might be better to bold "Recommended."
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | update_status_recommended_stripe_marvin.patch.txt | 753 bytes | dww |
| #8 | update_status_recommended_stripe_marvin.png | 106.22 KB | dww |
| #7 | update_status_recommended_stripe_garland.png | 96.11 KB | dww |
| #5 | highlight_security_update.patch_1.txt | 3.15 KB | dww |
| #3 | highlight_security_update.patch | 1.81 KB | merlinofchaos |
Comments
Comment #1
merlinofchaos commentedThis simple patch adds an extra class if there is a recommended and a latest, and that class gets the bolding. Recommended version doesn't fit in 13em if bolded, so width expands to 14em to accomodate.
Comment #2
merlinofchaos commenteddww wanted this to also highlight if a 'security update' is listed and not used. That was an easy enough change, and committed.
Comment #3
merlinofchaos commentedHere's a slight addendum based upon dww's comments via IRC. It highlights the security update IF there isn't a recommended version being listed next to it.
Comment #4
nancydruThanks
Comment #5
dwwSince #3 introduces an
elseclause to that funky special case that used to be written with inverted logic, it's actually much clearer to re-write theif. Attached patch does that, and also includes the conditional bold if there's both "Recommended" and "Also available".Comment #6
dwwmerlin gave his blessings for #5 in IRC, so I committed to HEAD.
Comment #7
dwwFYI -- there was a bug where we weren't bold'ing Recommended if we were just displaying that and a dev snapshot. Fixed: http://drupal.org/cvs?commit=71470
Also, in IRC, UnConeD and hunmonk suggested another visual enhancement to make the recommended line stick out and be more visually clear, even if there's only that 1 line. A subtle zebra stripe sort of thing with a slighly lighter shade of the color. Screenshot here from garland.
Comment #8
dwwSame, but screenshot with marvin enabled.
Comment #9
dwwAnd now, the trivial patch (just touches update_status.css).
Comment #10
dwwCommitted to HEAD (http://drupal.org/cvs?commit=71473). We can always tweak later if we must, but this is an improvement, IMHO.
Comment #11
(not verified) commented