A number of the form labels and menu titles go against Drupal coding standards by being all upper-case, ie, Manage Registrations, where it should be Manage registrations.

If you're receptive to this change I'll create a patch right now.

CommentFileSizeAuthor
#4 code-cleanup-1490982.patch42.11 KBdpi

Comments

dpi’s picture

dpi
Location Perth, Australia
commented

There is an overall issue of general Drupal coding standards compliance, even after you account for grammar issues.

This is a bigger issue, and it is probably better if a Coder run is made at some point in time. Preferably before 1.0 release to minimize patch disruption.

levelos’s picture

levelos commented

In short, sure, I'll welcome any coding standards patches.

seanberto’s picture

seanberto commented
Priority: Normal » Major

@dpi,

@levelos isn't likely to be touching the module this weekend. If you wanted to submit a patch after running Coder, this weekend would be a great time to avoid conflicts.

Bumping to "major" priority so that this stays at the top of our list.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new code-cleanup-1490982.patch42.11 KB

Code run through Coder strict and documentation cleaned up a little to match standards.

Some things of note that should be addressed (patch does not include):

  • Rearrange parameters of functions to match Drupal: $entity_type, $entity_id.
    • registration_has_room
    • registration_event_count
    • registration_entity_settings
    • registration_update_entity_settings
  • Add static variables for registration_entity_settings
levelos’s picture

levelos commented
Status: Needs review » Fixed

Thanks @dpi. The coder output and your suggested list are taken care of.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • levelos committed b22bf05 on 7.x-1.x, panels, any-entity, slots, integrations, hold_state authored by dpi 
    #1490982 by @dpi: Run through Coder in strict mode.